Add section on nested/multiline ternaries #673
Conversation
| : value1 > value2 ? "baz" : null; | ||
|
|
||
| //better | ||
| const maybeNull = value1 > value2 ? "baz" : null; |
There was a problem hiding this comment.
per our "quotes" rule, all the non-bad ones should use single quotes
|
In this node style guide they encourage multi-line ternaries, although no explanation is given why. https://github.com/felixge/node-style-guide#use-multi-line-ternary-operator |
|
Can we make this link to the relevant eslint rule(s)? |
|
linked to one rule, did you have others in mind? |
|
I think that's it :-) |
|
Seems like the discussion above about multiline ternaries has been resolved? Please share any further thoughts on the subject; I'd like to merge this within the next day or two. |
|
No additional thoughts here. |
|
@bgvianyc Would you mind one last rebase on this? I think it's time to merge it. |
|
How do you want it rebased? I only see one commit now. |
|
@bgvianyc just stacked on top of latest master so i can fast-forward merge it :-) |
add link to the relevant eslint rule
|
@ljharb done |
As per this issue: #671