-
Notifications
You must be signed in to change notification settings - Fork 26.8k
adding ternary operator along with example #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@hshoff any opinions here? |
Let's just add an extra bullet to Conditional Operators & Equality under (i realize there are fancier ways to write fizzbuzz) // bad
for (var i = 1; i <= 16; i++) {
var msg = i % 3 === 0 ? i % 5 === 0 ? 'FizzBuzz' : 'Fizz' : i % 5 === 0 ? 'Buzz' : '';
console.log(msg || i);
}
// good
for (var i = 1; i <= 16; i++) {
var msg = '';
if (i % 3 === 0) {
if (i % 5 === 0 {
msg = 'FizzBuzz';
} else {
msg = 'Fizz';
}
} else if (i % 5 === 0) {
msg = 'Buzz'
}
console.log(msg || i);
}
// good
var superpower = isSuperman(user) ? 'flight' : 'none'; |
@@ -568,9 +568,27 @@ | |||
|
|||
|
|||
|
|||
## Comparison Operators & Equality | |||
## Comparison Operators , Conditional (Ternary) Operators & Equality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use an Oxford comma here in this list - Comparison Operators, Conditional (Ternary) Operators, & Equality
Hello there, This cases should be resolved too :
or
|
Related to #673. |
msg = 'Buzz' | ||
} | ||
console.log(msg || i); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you keep this code, please fix indent.
No description provided.