Skip to content

feat(java): retry strategy APIC-261 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2022
Merged

feat(java): retry strategy APIC-261 #286

merged 3 commits into from
Mar 28, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Mar 24, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-261

Retry strategy for Java, heavily inspired by the existing one but modified to work with OkHTTP library using Interceptor. I'm sure a lot is missing with error handling but I will come in a later PR.

This also includes parametrics hosts for java, like the other languages.

Changes included:

  • Added Algolia exceptions
  • Some utils class
  • Retry strategy

🧪 Test

  • CI

@millotp millotp self-assigned this Mar 24, 2022
@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit eed9957
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62417060395b4400080d38a1

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team March 24, 2022 14:03
@millotp millotp force-pushed the feat/java-retry branch 2 times, most recently from d9dec7a to 8f4e8f5 Compare March 25, 2022 09:04
@shortcuts
Copy link
Member

shortcuts commented Mar 25, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! (from Java noob eyes)

Some suggested changes/questions

@millotp millotp requested a review from shortcuts March 25, 2022 15:46
@millotp millotp enabled auto-merge (squash) March 25, 2022 15:46
shortcuts
shortcuts previously approved these changes Mar 28, 2022
@millotp millotp merged commit e4a064f into main Mar 28, 2022
@millotp millotp deleted the feat/java-retry branch March 28, 2022 09:20
eunjae-lee pushed a commit to algolia/algoliasearch-client-java that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants