chore: Generated code for commit ad260df53c07cb46ed4353735159d1778a480a63. #303
Conversation
Co-authored-by: Clément Vannicatte <[email protected]>
shortcuts
requested review from
eunjae-lee and
damcou
and removed request for
a team
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shortcuts
changed the title
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -55,7 +55,7 @@ components: | |||
| period to analyze. | |||
| schema: | |||
| type: string | |||
| example: 1999-09-19T00:00:00.000Z | |||
There was a problem hiding this comment.
the pattern doesn't reflect the example anymore, the bundler changed ?
There was a problem hiding this comment.
Yes, it was one of the motivation of #300, the new output is better
There was a problem hiding this comment.
does the algolia API work with this format ? the doc only have simple date as example
There was a problem hiding this comment.
This issue was only present on the Documentation and bundled specs, generators does not take example into account
does the algolia API work with this format ?
no
There was a problem hiding this comment.
okay so now the doc is misleading, I don't get this change
I'm stupid I read the diff backward
There was a problem hiding this comment.
How come?
The example we defined was 1999-09-19, but the bundler outputted 1999-09-19T00:00:00.000Z, the bundle update in #300 fixed that
There was a problem hiding this comment.
I'm stupid I read the diff backward
Ah XD
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Clément Vannicatte [email protected]
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
🧪 Test
CI :D