Skip to content

chore: Generated code for commit ad260df53c07cb46ed4353735159d1778a480a63. #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2022
Merged

chore: Generated code for commit ad260df53c07cb46ed4353735159d1778a480a63. #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4813b95
Generated code for commit ad260df53c07cb46ed4353735159d1778a480a63.
Mar 28, 2022
c08b1ad
Merge branch 'main' into generated/main
shortcuts Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-abtesting/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-insights/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-personalization/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-predict/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-query-suggestions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-search/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/client-sources/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions clients/algoliasearch-client-javascript/packages/recommend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@experimental-api-clients-automation/requester-node-http": "0.0.5"
},
"devDependencies": {
"@types/node": "16.11.11",
"typescript": "4.5.4"
"@types/node": "16.11.26",
"typescript": "4.6.3"
}
}
4 changes: 2 additions & 2 deletions specs/bundled/analytics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ components:
period to analyze.
schema:
type: string
example: 1999-09-19T00:00:00.000Z
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pattern doesn't reflect the example anymore, the bundler changed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was one of the motivation of #300, the new output is better

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the algolia API work with this format ? the doc only have simple date as example

Copy link
Member Author

@shortcuts shortcuts Mar 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was only present on the Documentation and bundled specs, generators does not take example into account

does the algolia API work with this format ?

no

Copy link
Collaborator

@millotp millotp Mar 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay so now the doc is misleading, I don't get this change
I'm stupid I read the diff backward

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come?

The example we defined was 1999-09-19, but the bundler outputted 1999-09-19T00:00:00.000Z, the bundle update in #300 fixed that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stupid I read the diff backward

Ah XD

image

example: 1999-09-19
pattern: ^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$
EndDate:
in: query
Expand All @@ -65,7 +65,7 @@ components:
period to analyze.
schema:
type: string
example: 2000-01-21T00:00:00.000Z
example: 2000-01-21
pattern: ^\d{4}-(0[1-9]|1[0-2])-(0[1-9]|[12][0-9]|3[01])$
OrderBy:
in: query
Expand Down