chore(javascript): split build task to avoid memory issue #383
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -27,7 +27,7 @@ jobs: | |||
|
|
|||
| - name: Build clients | |||
| shell: bash | |||
| run: yarn build | |||
| run: yarn build:all | |||
There was a problem hiding this comment.
As I asked on slack, if this split part works, why don't we use a matrix? This way there's no conditional stuff added
There was a problem hiding this comment.
You mean stuff like createMatrix? It's because they won't be copied into the JS repo.
There was a problem hiding this comment.
I just mean creating a GitHub matrix, so each jobs are run in parallel in their own runners
There was a problem hiding this comment.
And part 2 of what I said on slack, runners are not shared with the JavaScript repository, which might also not help the memory limit as it runs on the default GH runners. (TBC)
compare https://github.com/algolia/api-clients-automation/settings/actions/runners to https://github.com/algolia/algoliasearch-client-javascript/settings/actions/runners
There was a problem hiding this comment.
only admin can see that page
There was a problem hiding this comment.
Okay, now I see what you mean by GitHub matrix. But how does it solve
This way there's no conditional stuff added
this problem?
And since we split the build into many, we don't have memory issue any more. Maximum 2~300MB is enough now.
There was a problem hiding this comment.
I managed to make the CLI work as before so you can ignore my comment if you prefer going with the bash solution
Co-authored-by: Pierre Millot <[email protected]>
* chore(javascript): split build task to avoid memory issue * Update clients/algoliasearch-client-javascript/rollup.config.js Co-authored-by: Pierre Millot <[email protected]> Co-authored-by: Pierre Millot <[email protected]>
🧭 What and Why
Changes included:
The JS build process dies due to heap memory limitation (more precisely because of how rollup adds up memory usage as it iterates over configs).
This PR splits the
yarn buildinto multiple. Every time a process ends, it will release memory, and this will fix our issue.The failed GHA: https://github.com/algolia/algoliasearch-client-javascript/runs/6035896998?check_suite_focus=true