fix(script): restore previous CLI build logic #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
approved these changes
Apr 15, 2022
| @@ -95,14 +95,18 @@ function getUtilConfigs() { | |||
| ]; | |||
| } | |||
|
|
|||
| function isClientBuilt(client) { | |||
| function shouldBuildUtil(utilClient) { | |||
There was a problem hiding this comment.
You can rebase on #383 to avoid touching this file.
Or not if you want to merge fast
There was a problem hiding this comment.
That's what I did first but since @eunjae-lee is off and I want to keep working on JS client it's better for me to merge :D
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
As seen in #383, changes in #371 introduced many changes regarding the JS build. This PR fixes issue at the CLI level of the monorepo:
distfoldersallruns for ~20 mins)This PR does not introduce changes on the rollup config other than what's in #383, so it should not interfere with @eunjae-lee's work but can allow us to work on JS clients until fixed.
🧪 Test
CI :D