feat(javascript): add waitForApiKey helper method
#738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
feat/javascript-add-wait-for-api-key
branch
from
8323151 to
8e1321a
Compare
shortcuts
commented
Jun 24, 2022
| @@ -25,13 +25,17 @@ type Prompt = { | |||
| interactive: boolean; | |||
| }; | |||
|
|
|||
| export function getClientChoices(job: Job, language?: LangArg): string[] { | |||
| const withoutAlgoliaSearch = PROMPT_CLIENTS.filter( | |||
| export function getClientChoices( | |||
There was a problem hiding this comment.
Sorry for this change, all was not allowed anymore 👼🏼
shortcuts
force-pushed
the
feat/javascript-add-wait-for-api-key
branch
from
ea9b088 to
c809fb4
Compare
shortcuts
force-pushed
the
feat/javascript-add-wait-for-api-key
branch
from
c809fb4 to
64163f4
Compare
shortcuts
force-pushed
the
feat/javascript-add-wait-for-api-key
branch
from
64163f4 to
9ed5b78
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
millotp
reviewed
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-514
Changes included:
The initial idea was to provide a guide for this solution, but due to the different way of ensuring the task has been processed, we decided to move to an helper method to ease the user journey.
We now provide a
waitForApiKeyhelper method, similarly towaitForTask, but with stop condition matching what was introduced in v4.🧪 Test