fix(javascript): improve bundlesize, add check to CI #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
millotp
previously approved these changes
Jun 28, 2022
shortcuts
force-pushed
the
fix/js-bundlesize
branch
from
831c932 to
70fd7ca
Compare
millotp
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
In #738, I forgot to check/increase the bundlesize, which also made me realize that we use
Object.entriesin the JS client, which is not supported in some (older/IE) browsers, and had huge impact on size (~60kb inalgoliasearch).In this PR, we now only leverage
Object.keys, and also check for the bundlesize in the CI, which allow us to catch those big increase issue.🧪 Test
CI :D