-
Notifications
You must be signed in to change notification settings - Fork 6.7k
please update 0.12 to npm ~ #3021
Comments
👍 |
1 similar comment
+1 |
Guys, I'm sorry, but we are not publishing to npm officially. Please contact owner of the package. |
@ws-malysheva could you please let angular-ui take over angular-bootstrap npm project? |
It looks like this has been unpublished. Are there any plans to republish this on npm? We have a project that depends on it. |
Just to let you know that in order to fix our build, the simplest solution was to republish the package under a temporary name on npm as angular-bootstrap-temporary. I'll be delighted to unpublish that hacky package as soon as an official package is published by the angular-ui team, so please just ping me here! Thanks, |
@pkozlowski-opensource any news on this? |
Would really like this on npm! |
I've published it at angular-bootstrap https://www.npmjs.com/package/angular-bootstrap it's version 0.12.0 because 0.13.0-SNAPSHOT was already uploaded, but it's the same. I've also invited the maintainers for angular-ui so that they can update the repo. |
Thanks for taking initiative @leon |
I'm going to reopen this so it's tracked on this side. |
@leon, could the "main" be |
There are a couple of differences between the package I've deployed and the standard angular-boostrap
check the pull request #3201 |
@kentcdodds What is the community standard for the "main" attribute? |
TL;DR - main should point to a single unminified file (best if it uses UMD) that exports the angular module name. As I've been converting a project from bower to npm, I've noticed some point to a But in most cases, the file that's pointed to is an unminified file. In many cases it's a UMD module. In an angular context, this isn't really important. However, I think the angular-ui-router project has it right when their export is the name of the module. This is nice because then I can do this: angular.module('myModule', [
require('angular-ui-router')
]); And I don't even need to know the name of the module. I think that I would consider this a best practice and would hope that the entire community follows this project. |
Also, I should have mentioned, but just to be clear. That single file should be browser shippable on its own. So it should be a concat of all the files necessary as well as all the templates necessary (via $templateCache for example) for the module to function. |
@kentcdodds I'll change my pull request to point to the unminified version. Does removing the version from the filename some how interfer with the bower release? |
The version should never be included as part of the filename because it prevents auto-updates from happening. Meaning, if I depend on version 1.0.1 then in my index.html (for example) I'll say: <script src="my-dependency-1.0.1.js"></script> Then if the maintainer of the project pushes a version 1.0.2, it breaks me or I don't get it, because bower would automatically update the package for me and unless the maintainer pushes all the previous versions as well, I'm going to break or not get it until I change to: <script src="my-dependency-1.0.2.js"></script> So the version should never be a part of the file name (unless you update the "main" but I would say that's just silly and just don't publish the file with the version number). |
@kentcdodds In my case the reference is in my gulp.js file, but the same applies there. |
@leon, just published this. Maybe it'll be helpful: How to distribute your AngularJS module |
Done. Will update README soon. |
npm's angular-bootstrap is still 0.11~~~~
The text was updated successfully, but these errors were encountered: