This repository was archived by the owner on May 29, 2019. It is now read-only.
update gulp build to better align with custom builds #3201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2015 13:13
The version should not be included in the dist filename because it breaks peoples grunt and gulp build's when a new version is released.
|
+1! When can we expect this to be merged? |
|
@chrisirhc & @Foxandxss, what are your thoughts on this? I believe you two are the ones familiar with the release process. This is a breaking change, but one that may be sensible to do since the file names should just be fixed. |
|
We need to rework the publishing process. Right now, the contents of the bootstrap-bower repository should be what's used for publishing to npm. That repository doesn't contain version numbers. |
|
I don't think this PR matches what we are doing with our releases. We are using an external repo and all the stuff we generate into /dist is merely internal only. If you think there is an issue yet, please open an issue for proper discussion. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the dist files should not contains the version since this breaks builds when a new version comes out.
The package.json is also updated to better align with npm