Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

chore(Gruntfile): Add commonjs package manager support #3388

Closed
wants to merge 2 commits into from
Closed

chore(Gruntfile): Add commonjs package manager support #3388

wants to merge 2 commits into from

Conversation

oznu
Copy link

@oznu oznu commented Mar 15, 2015

Adds support for commonjs/browserify when installed using NPM and allows injecting the module into an angular application like this:

var angular = require('angular');
angular.module('myApp', [
  require('angular-animate'),
  require('angular-ui-router'),
  require('angular-bootstrap'),
]);

@oznu
Copy link
Author

oznu commented Mar 15, 2015

#3021

@karianna karianna added this to the 0.13.0 milestone Mar 15, 2015
@chrisirhc chrisirhc modified the milestones: Backlog, 0.13.0 Mar 23, 2015
@chrisirhc
Copy link
Contributor

Moving this to Backlog as I don't think this is a priority for 0.13 . Also, curious as to whether this is the standard way to support Angular modules on CommonJS . I haven't done research/work on this myself. If anyone has any pointers, please post.

Also, note that this should modify meta.banner instead of just the banner on dist_tpls, to ensure that this is also done for the non--tpl file.

@chrisirhc
Copy link
Contributor

I see angular/angular.js#10732 now. Wasn't aware of it. Will look into this soon.

@chrisirhc chrisirhc modified the milestones: 0.13.x, Backlog Mar 26, 2015
@oznu
Copy link
Author

oznu commented Mar 31, 2015

Closed this PR as I messed it up. New one created at #3476 that takes into consideration the comments above.

@oznu oznu closed this Mar 31, 2015
@karianna karianna removed this from the 0.13.x milestone Mar 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants