This repository was archived by the owner on May 29, 2019. It is now read-only.
Added support for up/down arrow keys on timepicker #2316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability for the user to adjust hours or minutes for the timepicker by using the up/down keyboard arrow keys. This allow the user to adjust time without the need to use the mouse as they can simply tab across the input boxes (as I haven't used `e.preventDefault()`). By default the arrow keys are supported but this can be turned off by using an additional timepicker attribute `arrow-keys="false"`
|
@bekos it looks OK for me on the first sight but I'm going to leave this one in your hands. |
|
@GFoley83 LGTM, but I didn't understood why exactly you didn't use Also, you should add some tests in order to get this accepted. |
|
@bekos Adding I'll see if I have time to add tests later in the week. |
| hoursInputEl.bind('keydown', function(e) { | ||
| if ( e.which === 38 ) { | ||
| $scope.$apply($scope.incrementHours()); | ||
| } else if( e.which === 40 ){ |
|
Closing in favor of #4772. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability for the user to adjust hours and minutes for the timepicker by using the up/down keyboard arrow keys. This allow the user to adjust time without the need to use the mouse as they can simply tab across the input boxes (as I haven't used
e.preventDefault()for thekeydownevent).By default the arrow keys are supported but this can be turned off by using an additional timepicker attribute
arrow-keys="false"