This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(timepicker): have up/down arrow keys control time selection #3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hoursInputEl.bind('keydown', function(e) { | ||
| if ( e.which === 38 ) { // up | ||
| $scope.$apply(function() { | ||
| $scope.incrementHours(); |
There was a problem hiding this comment.
This should be rewritten as
$scope.incrementHours(); $scope.$apply();
| @@ -26,6 +27,11 @@ angular.module('ui.bootstrap.timepicker', []) | |||
| this.setupMousewheelEvents( hoursInputEl, minutesInputEl ); | |||
| } | |||
|
|
|||
| var arrowkeys = angular.isDefined($attrs.arrowkeys) ? $scope.$eval($attrs.arrowkeys) : timepickerConfig.arrowkeys; | |||
There was a problem hiding this comment.
I meant modify the directive scope to set arrowkeys: '=?'. It should be present by the time the init function is run, so you can directly pull the value from $scope.arrowkeys in that case.
There was a problem hiding this comment.
Actually upon looking at the rest of the source, change this back to $scope.$parent.$eval - I would rather have consistency with the rest of the source for now.
|
This LGTM once that change is made back to use $scope.$parent.$eval. |
…ope" This reverts commit 0027763.
|
@wesleycho would you like me to rebase this branch so that 0027763 and 8eb93ce are squashed? |
|
That won't be necessary, I can do the rebasing if needed. |
|
Landed as 2296115, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2316, but:
preventDefault.