Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

chore(Gruntfile): Add commonjs package manager support #3476

Closed
wants to merge 1 commit into from
Closed

chore(Gruntfile): Add commonjs package manager support #3476

wants to merge 1 commit into from

Conversation

oznu
Copy link

@oznu oznu commented Mar 31, 2015

Adds support for commonjs/browserify when installed using NPM and allows injecting the module into an angular application like this:

var angular = require('angular');
angular.module('myApp', [
  require('angular-animate'),
  require('angular-ui-router'),
  require('angular-bootstrap'),
]);

Implements same method used in angular/angular.js#10732 and angular-ui-router.

@wesleycho
Copy link
Contributor

This looks good, but upon discussion, we are scheduling this for 0.13.1 - we are close to releasing 0.13.0.

@chrisirhc
Copy link
Contributor

Before merging this, we should think about whether to publish the templates as a separate module (e.g. ui-bootstrap-tpls). Otherwise, with this change, users can't specify in the code whether they need the templates or not.

It may also make sense instead to publish the default ui-boostrap module with templates included and add another module called ui-boostrap-notpls .

@eranimo
Copy link

eranimo commented May 4, 2015

Any update on this? I'm surprised this package, given it's popularity, already doesn't have Browserify support

@ankurp
Copy link

ankurp commented May 7, 2015

Lets merge this to support browserify 👍

@nl0
Copy link

nl0 commented May 20, 2015

browserify ftw!

@wesleycho wesleycho modified the milestones: 0.13.1 (npm), 0.13.2 (Performance) Jul 23, 2015
@oznu
Copy link
Author

oznu commented Jul 28, 2015

This has been resolved with angular-ui/bootstrap-bower@c04f878

npm install angular-ui-bootstrap
var angular = require('angular');
angular.module('myApp', [
  require('angular-animate'),
  require('angular-ui-router'),
  require('angular-ui-bootstrap'),
]);

@oznu oznu closed this Jul 28, 2015
@oznu oznu deleted the commonjs_support branch July 28, 2015 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants