This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(datepicker): add monthColumns attribute #5650
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 18, 2016 09:48
Add ability to specify the number of columns on the month view of the datepicker
| @@ -19,7 +19,8 @@ angular.module('ui.bootstrap.datepicker', ['ui.bootstrap.dateparser', 'ui.bootst | |||
| shortcutPropagation: false, | |||
| showWeeks: true, | |||
| yearColumns: 5, | |||
| yearRows: 4 | |||
| yearRows: 4, | |||
| monthColumns: 4 | |||
There was a problem hiding this comment.
Default number it seems to replace is 3 - this is probably what is breaking the unit tests.
|
Linking related issue #5515 |
added 10 commits
March 18, 2016 10:37
|
Can you squash your commits? Doing Also tests can be run locally via |
|
@wesleycho this PR can be closed too as part of #5515 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to specify the number of columns on the month view of the datepicker