Skip to content

ui-grid-header-canvas bad height in v3.0.0-rc.21 on TreeView #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jibap opened this issue Apr 29, 2015 · 6 comments
Closed

ui-grid-header-canvas bad height in v3.0.0-rc.21 on TreeView #3382

jibap opened this issue Apr 29, 2015 · 6 comments

Comments

@jibap
Copy link

jibap commented Apr 29, 2015

Hi,

I use ui-grid in TreeView, in v3.0.0-rc.21-43f63ac
When i expand a node, the tree view row header height become bad (except first time).

image

I didn't have this issue in my previous version (Apr 24, 2015).

I exploit this issue to ask you another : i use externals filters and i want to edit filters dynamically.
I am able to edit them (visually) but they are not watched by filterChanged event ( i read a lot of issue talking about it, and i anderstand the reason for no watching all - explained in tutorial 316 ). But how to rebuild(redraw, refresh ??) the grid with my new options ?

image

About first issue, you can look in second picture when i add a filter, i use "notifyDataChange", and the tree view row header is recalculated good. So i tried to call it "on.rowExpanded" but it is not working....

Sorry for my english.

Thanks,

@meyerds
Copy link

meyerds commented Apr 29, 2015

I'm experiencing the same bug with grouping. I believe it was caused by this commit: 43f63ac - it works in the rc21 "stable" release but not in the latest unstable.

@AgDude
Copy link
Contributor

AgDude commented May 5, 2015

I think this is a duplicate of #3394

AgDude pushed a commit to AgDude/ui-grid that referenced this issue May 5, 2015
Refactor setting of header heights to be more DRY and ensure that rebuildStyles
is set when an explicit height is set. Do not set existing explicit heights to
 null before recalculating height.

 Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
AgDude pushed a commit to AgDude/ui-grid that referenced this issue May 7, 2015
Refactor setting of header heights to be more DRY and ensure that rebuildStyles
is set when an explicit height is set. Do not set existing explicit heights to
 null before recalculating height.

 Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
@PaulL1
Copy link
Contributor

PaulL1 commented May 16, 2015

I think the height portion of this is resolved, can you please confirm @jibap?

On the filters, it looks like your filters are using the ui-grid native filter logic, but you just want to apply the filtering using externalFiltering? If this is correct, then you should be getting a filterChanged event when the filter is edited - there is a watch on any filter box that ui-grid displays. The area we don't watch is if you programatically change a filter that is on a hidden column.

Do the filters that you use have a custom directive? Or are they entirely native? Could you provide a plunker and some instructions to recreate the issue?

@jibap
Copy link
Author

jibap commented May 16, 2015

Hi @PaulL1,

I try with v3.0.0-rc.21-869be69, but the issue still bad...

On the filters, sorry i forgot to precise, indeed i want to change filters programatically. The concept is having a "+" button which create a new filter row like this :
image
(you can see the first issue here !)

Finally i used a 'rowHeaderCol' for implementing the "+" and "trash" buttons with alignment of filters rows and i simply duplicate the "grid.colums.filters[0]" to add a new filter row. I add a "ng-change" attribute to my filters elements which update a scope variable containing terms values stored in filters. And then a function update(filtered and sorted) the data with this scope variable.
It works !! i have a multiple filtering.

@PaulL1
Copy link
Contributor

PaulL1 commented Jun 6, 2015

I think header height is now resolved. Closing.

@PaulL1 PaulL1 closed this as completed Jun 6, 2015
@jutoft
Copy link

jutoft commented Jun 10, 2015

I still have this issue.
Tested with unstable 2015-06-08.
The height is still 26px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants