-
Notifications
You must be signed in to change notification settings - Fork 2.5k
ui-grid-header-canvas bad height in v3.0.0-rc.21 on TreeView #3382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm experiencing the same bug with grouping. I believe it was caused by this commit: 43f63ac - it works in the rc21 "stable" release but not in the latest unstable. |
I think this is a duplicate of #3394 |
Refactor setting of header heights to be more DRY and ensure that rebuildStyles is set when an explicit height is set. Do not set existing explicit heights to null before recalculating height. Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
Refactor setting of header heights to be more DRY and ensure that rebuildStyles is set when an explicit height is set. Do not set existing explicit heights to null before recalculating height. Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
I think the height portion of this is resolved, can you please confirm @jibap? On the filters, it looks like your filters are using the ui-grid native filter logic, but you just want to apply the filtering using externalFiltering? If this is correct, then you should be getting a filterChanged event when the filter is edited - there is a watch on any filter box that ui-grid displays. The area we don't watch is if you programatically change a filter that is on a hidden column. Do the filters that you use have a custom directive? Or are they entirely native? Could you provide a plunker and some instructions to recreate the issue? |
Hi @PaulL1, I try with v3.0.0-rc.21-869be69, but the issue still bad... On the filters, sorry i forgot to precise, indeed i want to change filters programatically. The concept is having a "+" button which create a new filter row like this : Finally i used a 'rowHeaderCol' for implementing the "+" and "trash" buttons with alignment of filters rows and i simply duplicate the "grid.colums.filters[0]" to add a new filter row. I add a "ng-change" attribute to my filters elements which update a scope variable containing terms values stored in filters. And then a function update(filtered and sorted) the data with this scope variable. |
I think header height is now resolved. Closing. |
I still have this issue. |
Hi,
I use ui-grid in TreeView, in v3.0.0-rc.21-43f63ac
When i expand a node, the tree view row header height become bad (except first time).
I didn't have this issue in my previous version (Apr 24, 2015).
I exploit this issue to ask you another : i use externals filters and i want to edit filters dynamically.
I am able to edit them (visually) but they are not watched by filterChanged event ( i read a lot of issue talking about it, and i anderstand the reason for no watching all - explained in tutorial 316 ). But how to rebuild(redraw, refresh ??) the grid with my new options ?
About first issue, you can look in second picture when i add a filter, i use "notifyDataChange", and the tree view row header is recalculated good. So i tried to call it "on.rowExpanded" but it is not working....
Sorry for my english.
Thanks,
The text was updated successfully, but these errors were encountered: