Skip to content

ui-grid Grouping is broken #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepfriedbrain opened this issue May 3, 2015 · 3 comments
Closed

ui-grid Grouping is broken #3409

deepfriedbrain opened this issue May 3, 2015 · 3 comments

Comments

@deepfriedbrain
Copy link

In the tutorial example for Grouping for ui-grid, I noticed that the grouping is broken. The +/- signs are placed one row above their correct position after expansion. See the 2 screenshots of original un-expanded state and expanded state.

image

image

@AgDude
Copy link
Contributor

AgDude commented May 5, 2015

This is the same problem described in #3394. Thanks for the details, on when it occurred.

AgDude pushed a commit to AgDude/ui-grid that referenced this issue May 5, 2015
Refactor setting of header heights to be more DRY and ensure that rebuildStyles
is set when an explicit height is set. Do not set existing explicit heights to
 null before recalculating height.

 Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
AgDude pushed a commit to AgDude/ui-grid that referenced this issue May 7, 2015
Refactor setting of header heights to be more DRY and ensure that rebuildStyles
is set when an explicit height is set. Do not set existing explicit heights to
 null before recalculating height.

 Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
@PaulL1
Copy link
Contributor

PaulL1 commented May 25, 2015

Closing as duplicate.

@PaulL1 PaulL1 closed this as completed May 25, 2015
@springzen
Copy link

Build used: ui-grid - v3.1.1 - 2016-02-09
I know this is now closed, but I am not sure if this is the same issue or a new one. When I group, I am seeing the same issue as described originally. In my case this is related to my css. I was trying to add word wrap and I took the tip from #317.

.ui-grid-viewport .ui-grid-cell-contents {
    word-wrap: break-word;
    white-space: normal !important;
}

.ui-grid-row, .ui-grid-cell {
    height: auto !important;
}

.ui-grid-row div[role=row] {
    display: flex;
    align-content: stretch;
}

If I use this css, only the headers wrap.

.ui-grid-header-cell .ui-grid-cell-contents {
    /*height: 48px;*/
    white-space: normal;
    -ms-text-overflow: clip;
    -o-text-overflow: clip;
    text-overflow: clip;
    overflow: visible;
    word-wrap: break-word;
}

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants