docs(tutorial/10 - Event Handlers): describe your change...

[heidi-jungel]

Added ngKeypress directive to support keyboard only users for WCAG 2.0 Level A, 2.1.1 Keyboard Accessibility. To support and encourage developers to think about accessibility these should be clickable to keyboard only users.

[gkalpak]

Even though I think promoting accessibility is important, I feel like this change is out of scope.
Note that the same effect could be achieved by using ngAria.

[heidi-jungel]

I work for a company that reviews accessible code. We are seeing developers follow these exact tutorial steps, missing on accessibility. If we can incorporate accessible code as users are learning angular, this becomes second nature.

The way we have it, they have to retrofit after they have coded.

On Oct 5, 2015, at 7:26 AM, Georgios Kalpakas [email protected] wrote:

Even though I think promoting accessibility is important, I feel like this change is out of scope.
Note that the same effect could be achieved by using ngAria.

—
Reply to this email directly or view it on GitHub.

[gkalpak]

I case I wasn't clear:

I too believe that a11y is important and promiting good practices in example code and tutorials is paramount to building "good developer habbits" (wrt to a11y). In fact, we (read @marcysutton) have recently-ish gone though all docs examples and improved a11y (see #11079).

Yet, the functionality added by this change is already built-into ngAria, so the user would get it for free just by adding ngAria as a dependency to their module. Considering this is a tutorial (so people are learning new concepts), I think it's best to keep it at the absolute minimum. This change adds clutter which may make it more difficult for inexperienced users to focus on what is being taught here.

While I am OK with simple/small changes that improve a11y without introducing "mental" overhead (e.g. #12946), I believe that the tutorial is not the place for more complex stuff. Even more so, if the same functionality (plus a ton more) can be easily achieved by using ngAria as a dependency.

I think it would be nice to more explicitly mention ngAria and what it offers in the tutorial (either in the introduction or in a dedicated step) and/or point to relevant docs.

WDYT, @gilesedinburgh ?

/cc @petebacondarwin

[petebacondarwin]

I agree with @gkalpak. Perhaps we should indeed consider a dedicated step in the tutorial where we implement ngAria? That would be nice.

[heidi-jungel]

I “third" that agreement!

On Oct 5, 2015, at 8:49 AM, Pete Bacon Darwin [email protected] wrote:

I agree with @gkalpak. Perhaps we should indeed consider a dedicated step in the tutorial where we implement ngAria? That would be nice.

—
Reply to this email directly or view it on GitHub.

[gkalpak]

@gilesedinburgh, would you be up to creating a PR ? (Even if not 100% complete, it could serve as a starting point and get some discussion going.)

[heidi-jungel]

Sure. I can certainly do that. It might take me a couple of days, but I will get one started.

Thanks!

On Oct 13, 2015, at 10:18 AM, Georgios Kalpakas [email protected] wrote:

@gilesedinburgh, would you be up to creating a PR ? (Even if not 100% complete, it could serve as a starting point and get some discussion going.)

—
Reply to this email directly or view it on GitHub.

[gkalpak]

That's awesome. Thx !