docs(tutorial/6 - Templating Links #12946

heidi-jungel · 2015-09-25T12:56:13Z

Updating to include the alt attribute for the image. Per WCAG 2.0 Level A 1.1.1, all images must have alternative text. Since this is likely a tutorial developers will follow, better to include accessibility while they are learning angular and show how it can be done with angular.

googlebot · 2015-09-25T12:56:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

heidi-jungel · 2015-09-25T13:01:23Z

requesting to add alt attribute to tutorial file

heidi-jungel · 2015-09-25T13:11:29Z

I signed it!

googlebot · 2015-09-25T13:11:34Z

CLAs look good, thanks!

gkalpak · 2015-09-25T14:05:02Z

docs/content/tutorial/step_06.ngdoc

@@ -43,7 +44,7 @@ __`app/index.html`:__
 ...
        <ul class="phones">
          <li ng-repeat="phone in phones | filter:query | orderBy:orderProp" class="thumbnail">
-            <a href="#/phones/{{phone.id}}" class="thumb"><img ng-src="{{phone.imageUrl}}"></a>
+            <a href="#/phones/{{phone.id}}" class="thumb"><img ng-src="{{phone.imageUrl}}" alt="{{phone.alt}}></a>


Missing closing quote.

Added missing closing quote

gkalpak · 2015-10-05T11:41:04Z

I tool a closer look. If we are adding alt, I think we should be consistent. This means that similar changes are needed in steps 5, 10 and 12 as well as in the angular-phonecat repo.

heidi-jungel · 2015-10-05T12:08:01Z

I totally agree! We should have these in all steps for consistency. I can certainly make that request for each of these steps.

On Oct 5, 2015, at 7:43 AM, Georgios Kalpakas [email protected] wrote:

I tool a closer look. If we are adding alt, I think we should be consistent. This means that similar changes are needed in steps 5, 10 and 12 as well as in the angular-phonecat repo.

—
Reply to this email directly or view it on GitHub.

gkalpak · 2015-10-05T12:37:42Z

@gilesedinburgh, awesome ! I think it would be best to make all changes in one PR (plus one more for the angular-phonecat repo).

Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223

@teropa

This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223

@teropa

This is a major re-structuring of the tutorial app's codebase, aiming at applying established best practices (in terms of file naming/layout and code organization) and utilizing several new features and enhancements (most notably components) introduced in recent versions of Angular (especially v1.5). Apart from the overall changes, two new chapters were introduced: one on components and one on code organization. -- In the process, several other things were (incidentally) taken care of, including: * Dependencies were upgraded to latest versions. * Animations were polished. * Outdated links were updated. * The app's base URL was changed to `/` (instead of `/app/`). BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked fine: * 0.11.16 * 4.2.6 * 4.4.2 * 5.10.0 -- This was inspired by (and loosely based on) angular#13834. Again, mad props to @teropa for leading the way :) -- **Note:** The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been saved on the `pre-v1.5.0-snapshot` branch of [angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the tutorial should be pointed to that branch instead of `master`. -- Related to angular/angular-phonecat#326. Related to angular/angular-seed#329. Related to angular/angular-seed#333. --- Fixes angular#12755 Fixes angular#13312 Fixes angular#13623 Fixes angular#13632 Closes angular#8952 Closes angular#11726 Closes angular#12946 Closes angular#12947 Closes angular#13198 Closes angular#13284 Closes angular#13834 Closes angular#14178 Closes angular#14223

gkalpak · 2016-05-25T13:10:40Z

Closed with c2033d7.

googlebot added the cla: no label Sep 25, 2015

googlebot added cla: yes and removed cla: no labels Sep 25, 2015

gkalpak reviewed Sep 25, 2015
View reviewed changes

Update step_06.ngdoc

e72b726

Added missing closing quote

gkalpak mentioned this pull request Oct 5, 2015

docs(tutorial/7 - Routing #12947

Closed

gkalpak mentioned this pull request Oct 5, 2015

docs(tutorial/10 - Event Handlers): describe your change... #12948

Closed

Narretz added the type: docs label Oct 8, 2015

Narretz added this to the Backlog milestone Oct 8, 2015

Narretz force-pushed the master branch from 70049ae to b77e14b Compare January 16, 2016 21:59

petebacondarwin modified the milestones: Phonecat Tutorial Overhaul, Backlog Jan 25, 2016

gkalpak mentioned this pull request Apr 12, 2016

docs(tutorial): update to use v1.5.x and best practices #14416

Closed

gkalpak closed this May 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(tutorial/6 - Templating Links #12946

docs(tutorial/6 - Templating Links #12946

heidi-jungel commented Sep 25, 2015

googlebot commented Sep 25, 2015

heidi-jungel commented Sep 25, 2015

heidi-jungel commented Sep 25, 2015

googlebot commented Sep 25, 2015

gkalpak Sep 25, 2015

gkalpak commented Oct 5, 2015

heidi-jungel commented Oct 5, 2015

gkalpak commented Oct 5, 2015

gkalpak commented May 25, 2016

docs(tutorial/6 - Templating Links #12946

docs(tutorial/6 - Templating Links #12946

Conversation

heidi-jungel commented Sep 25, 2015

googlebot commented Sep 25, 2015

heidi-jungel commented Sep 25, 2015

heidi-jungel commented Sep 25, 2015

googlebot commented Sep 25, 2015

gkalpak Sep 25, 2015

Choose a reason for hiding this comment

gkalpak commented Oct 5, 2015

heidi-jungel commented Oct 5, 2015

gkalpak commented Oct 5, 2015

gkalpak commented May 25, 2016