Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update step_03.ngdoc #8952

Closed
wants to merge 1 commit into from
Closed

Update step_03.ngdoc #8952

wants to merge 1 commit into from

Conversation

fmagnan
Copy link

@fmagnan fmagnan commented Sep 5, 2014

Hello,

when I run protactor, I got this error message:

Failures:
1) PhoneCat App Phone list view should display the current filter value in the title bar
Message: ReferenceError: query is not defined
Stacktrace: ReferenceError: query is not defined

It's because query is not retrieved from model. So I added it.

Hope this helps

Hello,

when I run protactor, I got this error message:
```
Failures:
1) PhoneCat App Phone list view should display the current filter value in the title bar
Message: ReferenceError: query is not defined
Stacktrace: ReferenceError: query is not defined
```

It's because query is not retrieved from model. So I added it.

Hope this helps
@caitp
Copy link
Contributor

caitp commented Sep 5, 2014

This test is literally supposed to fail, please read the sentence following this code snippet

@caitp
Copy link
Contributor

caitp commented Sep 5, 2014

@petebacondarwin I am pretty sure the reference error is not the reason the test is supposed to fail though, we probably should put the query declaration after browser.get() in beforeEach()

@petebacondarwin
Copy link
Contributor

Protractor doesn't care about these declarations being inside beforeEach since they are executed lazily when you put them inside a matcher - which is why we can create PageObjects for protractor specs.

I suspect that people are not copying the declaration of the query variable into their own code. So if it makes people less likely to complain that it is broken we should move it.

Also we should make the fact that this test is expected to fail more obvious no? Perhaps put it in the sentence before the code.

@fmagnan
Copy link
Author

fmagnan commented Sep 5, 2014

Hello,
thank you very much for your reply. The test is supposed to fail because we put query in title and title tag is not in scope. So, I did what the documentation said and I moved ng-controller in html tag and protractor still failed.

I think it's because query is not defined in protactor test. If you look at the previous test ("should filter the phone list as user types into the search box") you can see that query is retrieved from model.

So, I did the same and protractor run without errors.

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@btford btford added this to the Backlog milestone Sep 8, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:09
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:38
@petebacondarwin petebacondarwin modified the milestones: Phonecat Tutorial Overhaul, Backlog Jan 25, 2016
gkalpak added a commit to gkalpak/angular.js that referenced this pull request Apr 12, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best
practices (in terms of file naming/layout and code organization) and utilizing several new features
and enhancements (most notably components) introduced in recent versions of Angular (especially
v1.5).

Apart from the overall changes, two new chapters were introduced: one on components and one on code
organization.

--
In the process, several other things were (incidentally) taken care of, including:

* Dependencies were upgraded to latest versions.
* Animations were polished.
* Outdated links were updated.
* The app's base URL was changed to `/` (instead of `/app/`).

BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked
fine:

* 0.11.16
* 4.2.6
* 4.4.2
* 5.10.0

--
This was inspired by (and loosely based on) angular#13834.
Again, mad props to @teropa for leading the way :)

--
**Note:**
The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been
saved on the `pre-v1.5.0-snapshot` branch of
[angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the
tutorial should be pointed to that branch instead of `master`.

--
Related to angular/angular-phonecat#326.
Related to angular/angular-seed#329.
Related to angular/angular-seed#333.

---
Fixes angular#12755
Fixes angular#13312
Fixes angular#13623
Fixes angular#13632

Closes angular#8952
Closes angular#11726
Closes angular#12946
Closes angular#12947
Closes angular#13198
Closes angular#13284
Closes angular#13834
Closes angular#14178
Closes angular#14223
gkalpak added a commit to gkalpak/angular.js that referenced this pull request May 24, 2016
This is a major re-structuring of the tutorial app's codebase, aiming at applying established best
practices (in terms of file naming/layout and code organization) and utilizing several new features
and enhancements (most notably components) introduced in recent versions of Angular (especially
v1.5).

Apart from the overall changes, two new chapters were introduced: one on components and one on code
organization.

--
In the process, several other things were (incidentally) taken care of, including:

* Dependencies were upgraded to latest versions.
* Animations were polished.
* Outdated links were updated.
* The app's base URL was changed to `/` (instead of `/app/`).

BTW, this has been tested with the following versions of Node (on Windows 10) and everything worked
fine:

* 0.11.16
* 4.2.6
* 4.4.2
* 5.10.0

--
This was inspired by (and loosely based on) angular#13834.
Again, mad props to @teropa for leading the way :)

--
**Note:**
The old version of the tutorial, that is compatible with Angular version 1.4 or older, has been
saved on the `pre-v1.5.0-snapshot` branch of
[angular-phonecat](https://github.com/angular/angular-phonecat). The `v1.4.x` version of the
tutorial should be pointed to that branch instead of `master`.

--
Related to angular/angular-phonecat#326.
Related to angular/angular-seed#329.
Related to angular/angular-seed#333.

---
Fixes angular#12755
Fixes angular#13312
Fixes angular#13623
Fixes angular#13632

Closes angular#8952
Closes angular#11726
Closes angular#12946
Closes angular#12947
Closes angular#13198
Closes angular#13284
Closes angular#13834
Closes angular#14178
Closes angular#14223
@gkalpak
Copy link
Member

gkalpak commented May 25, 2016

Closed with c2033d7.

@gkalpak gkalpak closed this May 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants