chore: add @__PURE__ annotation to ES5 output for uglify
#4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Apr 18, 2017
| // Prefix downleveled classes that extend another class w/ the @__PURE__ annotation | ||
| .replace( | ||
| /^(var (\S+) = )(\(function \(_super\) \{\n __extends\(\2, _super\);\n)/mg, | ||
| '$1/*@__PURE__*/$3' |
There was a problem hiding this comment.
Should we move that RegExp to a constant as well?
There was a problem hiding this comment.
I only moved the first one because it's over 100 characters long and needed to be wrapped in a string.
There was a problem hiding this comment.
Fine by me. Just think that it would be more clean if you have it like a stream (just running transformers)
But since its mostly temporary.. doesn't matter.
|
Also yes, I did test it with material.angular.io and seems to work fine. |
mmalerba
approved these changes
Apr 18, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://gist.github.com/IgorMinar/09eadcb221a8253162078210639a344d