Pin the selenium-webdriver version so that it correctly matches protractor. #42
Conversation
Add some console logging, remove useless info about the last running task in the control flow, and fix error where problems reported from done.fail were getting pushed into the following spec. Closes angular#18
Test wrapping for Jasmine 2 now more closely follows the test wrapping for Mocha at https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/testing/index.js This also adds more information to the task names in the control flow, for easier debugging.
Note: this means that using `this.addMatchers` no longer works inside before blocks or specs. It should have been changed to `jamsine.addMatchers` since the upgrade to Jasmine 2. It was still working by accident up until the previous commit.
Update selenium-webdriver to 2.47.0 from 2.45.1. This update introduces a convoluted situation where some tests in Proractor's suite would hang - see angular/protractor#2245 This change includes a fix for those issues which removes the explicit `flow.execute` wrapper around `expect` calls. This appears not to introduce any issues to existing tests.
… queue Instead, expectations without promises in either expected or actual are unchanged from the original Jasmine implementation. See angular/protractor#2894
Latest selenium-webdriver no longer supports node 0.12. Stop testing on it.
…ual is not a promise See angular/protractor#2964
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
EricHeath-AI
force-pushed
the
pin-webdriver-version
branch
from
a1d8a14 to
71f28c3
Compare
|
I'm not sure what the build failure means here. Google closures were not happy with my change? |
EricHeath-AI
force-pushed
the
pin-webdriver-version
branch
from
71f28c3 to
c15c365
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
When the library versions differ at runtime you get strange test behaviour where the jasmine wrappers do not evaluate the control flow correctly.
More details here: angular/protractor#2790