Skip to content

Pin the selenium-webdriver version so that it correctly matches protractor. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
acaec8b
feat(index): add jasmine2.0 support
hankduan Jan 3, 2015
fdb03a3
docs(readme): add note about jasmine 1 vs jasmine 2
juliemr Jan 30, 2015
161e1fa
fix(errors): update webdriverjs, fix asynchronous error output
juliemr Mar 17, 2015
759dc73
chore(release): version bump for 0.0.3
juliemr Mar 18, 2015
c0f13d2
refactor(asyncTestFn): refactor async test wrapping to show more info
juliemr Apr 13, 2015
8f8b8b3
tests(context): test that the `this` variable points to the right thing
juliemr Apr 14, 2015
e758e2f
chore(release): version bump for 0.0.4
juliemr Apr 14, 2015
6eb4301
tests(beforeall): add tests to verify beforeAll working with async
juliemr Apr 14, 2015
037c7de
chore(dependencies): update Jasmine to 2.3.1
juliemr May 14, 2015
521939b
chore(release): changelog and version bump for 0.0.5
juliemr May 15, 2015
4776c16
chore(selenium-webdriver): update selenium webdriver to 2.47.0
juliemr Sep 29, 2015
7a91295
chore(ci): Use container based travis and test against node 4
juliemr Sep 29, 2015
764b432
chore(release): version bump and changelog for 0.0.6
juliemr Sep 29, 2015
f4c30a0
fix: allow empty it functions
juliemr Oct 2, 2015
55fd11e
fix(index): forward it's return value
Jan 8, 2016
9c2083e
chore(release): version bump and changelog for 0.0.7
juliemr Feb 8, 2016
550dd96
chore(test): print command line
juliemr Feb 8, 2016
38748af
chore(test): add a test to make sure that asynchronous failures fail
juliemr Feb 8, 2016
4717c0b
chore: npmignore scripts
juliemr Feb 8, 2016
750898c
fix(expectation): expectations without promises no longer add to task…
juliemr Feb 9, 2016
5abc745
chore(jasmine): update MatchFactory to allow message as function
juliemr Feb 9, 2016
6bb173b
chore(release): changelog and version bump for 0.0.8
juliemr Feb 9, 2016
b48551b
chore(travis): don't test on node 0.12
juliemr Feb 9, 2016
790c81e
fix(expectations): allow custom matchers to return a promise when act…
sjurba Feb 26, 2016
c15c365
Pin the selenium-webdriver version so that it correctly matches protr…
EricHeath-AI Mar 20, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
node_modules/
spec/
scripts/
.travis.yml
.npmignore
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
sudo: false
language: node_js
node_js:
- "0.10"
- "4"

script:
- npm test
83 changes: 57 additions & 26 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,42 +1,73 @@
# 1.1.0
# Changelog for jasminewd2

## Dependency Updates
- ([daa67d6])(https://github.com/angular/jasminewd/commit/daa67d6eabdd9c70306748da8a0dc0a6f2edb90f)) chore(dependencies): update to selenium-webdriver 2.43.4
# 0.0.8

# 1.0.4
## Bug Fixes
- ([a088e6f](https://github.com/angular/jasminewd/commit/a088e6f175ca817f59d5eea99549e45ab5861ce0)) fix(timeouts): should call special timeout handlers only for a jasmine timeout
- ([5abc745](https://github.com/angular/protractor/commit/5abc7457cd73a4a4ba70b3c9ceeadac6d42bbd76))
chore(jasmine): update MatchFactory to allow message as function

Previously, it used to call the resets if anything matched 'timeout'. This was too
vague, since many error messages contain that string.
- ([750898c](https://github.com/angular/protractor/commit/750898c90a1cc1bef09384b60ef6e15adfe734f7))
fix(expectation): expectations without promises no longer add to task queue

Closes #8
Instead, expectations without promises in either expected or actual are unchanged from the
original Jasmine implementation.

# 1.0.3
## Bug Fixes
- ([00821b3](https://github.com/angular/jasminewd/commit/00821b3180a6674012fdccab106835f5ce94bb3f)) fix(timeout): better messaging if the control flow does not have a listed last task
See https://github.com/angular/protractor/issues/2894

# 1.0.2
# 0.0.7

## Bug Fixes
- ([30b6811](https://github.com/angular/jasminewd/commit/30b68113759a7cb5c8dabc5b16ffcd89516882d8)) fix(timeout): output more information about the current task when a timeout occurs
- ([55fd11e](https://github.com/angular/protractor/commit/55fd11e69c2f1ba8fba9a19a8acccbe933896084))
fix(index): forward it's return value

# 1.0.1
- ([f4c30a0](https://github.com/angular/protractor/commit/f4c30a0023c6ec33b15df762226c3fe8e741d26e))
fix: allow empty it functions

## Bug Fixes
- ([c507b37](https://github.com/angular/jasminewd/commit/c507b37dd04cf267a437a579fc3b14063abb2ef8))
fix(index): stop infinite promise resolution
# 0.0.6

1.0.0
=====
- ([4776c16](https://github.com/angular/jasminewd/commit/4776c16b9a9f3a9a3de8a8dddc0e051cb32331b4))
chore(selenium-webdriver): update selenium webdriver to 2.47.0

Support for Jasmine 1.3.1. Tested against minijasminenode @ 0.4.0.
Update selenium-webdriver to 2.47.0 from 2.45.1. This update introduces a convoluted situation
where some tests in Proractor's suite would hang - see
https://github.com/angular/protractor/issues/2245

Features
This change includes a fix for those issues which removes the explicit
`flow.execute` wrapper around `expect` calls. This appears not to introduce any issues to existing
tests.

- Automatically makes tests asynchronously wait until the WebDriverJS control flow is empty.
# 0.0.5

- If a `done` function is passed to the test, waits for both the control flow and until done is called.
- ([037c7de](https://github.com/angular/jasminewd/commit/037c7de7fea4de068734b6fa250d145800863633))
chore(dependencies): update Jasmine to 2.3.1

- Enhances `expect` so that it automatically unwraps promises before performing the assertion.
# 0.0.4

- ([8f8b8b3](https://github.com/angular/jasminewd/commit/8f8b8b39e779559fd3b29b138d7577658b8a64b7))
tests(context): test that the `this` variable points to the right thing

Note: this means that using `this.addMatchers` no longer works inside before blocks or specs. It
should have been changed to `jamsine.addMatchers` since the upgrade to Jasmine 2. It was still
working by accident up until the previous commit.

- ([c0f13d2](https://github.com/angular/jasminewd/commit/c0f13d254966c859db22d020a5390138dbf48e64))
refactor(asyncTestFn): refactor async test wrapping to show more info

Test wrapping for Jasmine 2 now more closely follows the test wrapping for Mocha at
https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/testing/index.js

This also adds more information to the task names in the control flow, for easier debugging.

# 0.0.3

- ([161e1fa](https://github.com/angular/jasminewd/commit/161e1fa48deaa5ea0f485027ea8ae41562864936))
fix(errors): update webdriverjs, fix asynchronous error output

Add some console logging, remove useless info about the last running task in the control flow, and
fix error where problems reported from done.fail were getting pushed into the following spec.

Closes #18

- ([fdb03a3](https://github.com/angular/jasminewd/commit/fdb03a388d4846952c09fb0ad75a37b46674c750))
docs(readme): add note about jasmine 1 vs jasmine 2

- ([acaec8b](https://github.com/angular/jasminewd/commit/acaec8bdd157e9933d608c66204a52335fb46ee4))
feat(index): add jasmine2.0 support
14 changes: 10 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ jasminewd [![Build Status](https://travis-ci.org/angular/jasminewd.png?branch=ma

Adapter for Jasmine-to-WebDriverJS. Used by [Protractor](http://www.github.com/angular/protractor).

**Important:** There are two active branches of jasminewd.

- [master](https://github.com/angular/jasminewd/tree/master) is an adapter for Jasmine 1.3, and uses the package minijasminenode. It is published to npm as `jasminewd`.
- [jasminewd2](https://github.com/angular/jasminewd/tree/jasminewd2) is an adapter for Jasmine 2.x, and uses the package jasmine. It is published to npm as `jasminewd2`.

Features
--------
Expand All @@ -16,7 +20,7 @@ Features
Installation
------------
```
npm install jasminewd
npm install jasminewd2
```

Usage
Expand All @@ -26,15 +30,17 @@ Assumes selenium-webdriver as a peer dependency.

```js
// In your setup.
var minijn = require('minijasminenode');
require('jasminewd');
var JasmineRunner = require('jasmine');
var jrunner = new JasmineRunner();
require('jasminewd2');

global.driver = new webdriver.Builder().
usingServer('http://localhost:4444/wd/hub').
withCapabilities({browserName: 'chrome'}).
build();

minijn.executeSpecs(/* ... */);
jrunner.projectBaseDir = '';
jrunner.execute(['**/*_spec.js']);

// In your tests

Expand Down
Loading