Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Change the background color of material website to make it more accessible #398

Closed
amcdnl opened this issue Feb 18, 2018 · 1 comment · Fixed by #635
Closed

Change the background color of material website to make it more accessible #398

amcdnl opened this issue Feb 18, 2018 · 1 comment · Fixed by #635
Assignees
@Splaktar
Labels
a11y has pr P2: required

Comments

@amcdnl
Copy link
Contributor

amcdnl commented Feb 18, 2018 •
edited
Loading

Reference: angular/components#9339

material angular1

material angular2

material angular3

material2-table

cdk-table

Per @jelbourn:

It does look like many of the syntax highlighting colors don't meet W3C contrast standards
@amcdnl amcdnl self-assigned this Feb 18, 2018
@amcdnl amcdnl mentioned this issue Feb 18, 2018
Closed
@amcdnl
Copy link
Contributor Author

amcdnl commented Feb 18, 2018 •
edited
Loading

@jelbourn - We just changed these styles per #301 to reflect https://developers.google.com/web/fundamentals/architecture/app-shell.

I do agree the methods and table look bad. I'll look into those.

amcdnl added a commit to amcdnl/material.angular.io that referenced this issue Feb 18, 2018
@amcdnl
fix: update title background angular#398
0c80e2e
@amcdnl amcdnl mentioned this issue Feb 18, 2018
Merged
jelbourn pushed a commit that referenced this issue Feb 18, 2018
@amcdnl @jelbourn
fix: update title background #398 (#399)
f1e612c
@Splaktar Splaktar assigned Splaktar and unassigned amcdnl Sep 20, 2019
Splaktar added a commit that referenced this issue Sep 20, 2019
@Splaktar
fix(a11y): various issues with contrast ratios
f41070c 
Fixes #398. Reverts #399.
@Splaktar Splaktar mentioned this issue Sep 20, 2019
Merged
@Splaktar Splaktar changed the title Change the background color of material website to make it more readable Change the background color of material website to make it more accessible Sep 20, 2019
jelbourn pushed a commit that referenced this issue Sep 20, 2019
@Splaktar @jelbourn
fix(a11y): various issues with contrast ratios (#635)
13f46a1 
Fixes #398. Reverts #399.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
a11y has pr P2: required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(a11y): various issues with contrast ratios angular/material.angular.io
2 participants
@amcdnl @Splaktar