Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Typings for ProtractorPlugin missing from index.d.ts in Protractor 4.0.0 #3365

Closed
jan-molak opened this issue Jul 13, 2016 · 2 comments · Fixed by #3389
Closed

Typings for ProtractorPlugin missing from index.d.ts in Protractor 4.0.0 #3365

jan-molak opened this issue Jul 13, 2016 · 2 comments · Fixed by #3389
Assignees

Comments

@jan-molak
Copy link
Contributor

Hi there,

It seems like the definition of the ProtractorPlugin is no longer accessible to plugin developers.

This definition used to be available from the protractor/built/plugins package as per the docs here:

import {ProtractorPlugin} from 'protractor/built/plugins';

but as Protractor 4.0.0 does not include this definition in the main built/index.d.ts nor does it provide definitions at protractor/built/plugins/, the class is beyond reach.

Could you please expose it in the main definitions file please?

Many thanks,
Jan

@jan-molak jan-molak changed the title ProtractorPlugin definition missing from index.d.ts in Protractor 4.0.0 Typings for ProtractorPlugin missing from index.d.ts in Protractor 4.0.0 Jul 13, 2016
@juliemr
Copy link
Member

juliemr commented Jul 13, 2016

We just need to add this to our output files.

@jan-molak
Copy link
Contributor Author

Thanks Julie, that would be great 👍

cnishina added a commit to cnishina/protractor that referenced this issue Jul 18, 2016
cnishina added a commit to cnishina/protractor that referenced this issue Jul 20, 2016
@juliemr juliemr modified the milestone: 4.0.1 Jul 20, 2016
cnishina added a commit that referenced this issue Jul 21, 2016
* output plugin typings
* change ProtractorPlugin to an interface
* doc clean up

closes #3365
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants