fix(types): output plugin typings #3389

cnishina · 2016-07-18T23:45:00Z

cnishina · 2016-07-19T04:50:52Z

change protractor plugins to an interface; however, more direction is needed for:

addSuccess: ({specName: 'hello world'})

cnishina · 2016-07-19T05:54:00Z

@sjelin will need input for above ^^

sjelin · 2016-07-19T23:53:05Z

docs/plugins.md

 };
+
+module.exports = myPlugin;
+
 ```

 Then, in a separate file, export an instance of that class using an assignment


Delete the part about the separate file now yeah?

sjelin · 2016-07-19T23:58:55Z

Should be good with some minor doc fixes

sjelin · 2016-07-21T00:41:35Z

LGTM

googlebot added the cla: yes label Jul 18, 2016

cnishina force-pushed the types_plugins branch 2 times, most recently from 20ab5c9 to 634272d Compare July 19, 2016 21:37

cnishina assigned sjelin Jul 19, 2016

cnishina added the pr: needs review label Jul 19, 2016

sjelin reviewed Jul 19, 2016
View reviewed changes

sjelin added pr: needs cleanup and removed pr: needs review labels Jul 19, 2016

cnishina added 3 commits July 19, 2016 17:08

fix(types): output plugin typings

929fce4

closes angular#3365

change ProtractorPlugin to an interface

3b598de

doc clean up

528bd6f

cnishina force-pushed the types_plugins branch from 634272d to 528bd6f Compare July 20, 2016 00:19

cnishina removed the pr: needs cleanup label Jul 21, 2016

sjelin added the pr: LGTM label Jul 21, 2016

cnishina merged commit b2eaa29 into angular:master Jul 21, 2016

cnishina deleted the types_plugins branch July 28, 2016 20:40

Provide feedback