This repository was archived by the owner on Jul 29, 2024. It is now read-only.
chore(driverProviders): add warnings to extra driver provider parameters #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
warn_configparser
branch
from
437462f to
a317b84
Compare
sjelin
approved these changes
Dec 22, 2016
| warn += 'local' !== providerType && config.seleniumServerJar ? 'seleniumServerJar, ' : ''; | ||
| warn += 'mock' !== providerType && config.mockSelenium ? 'mockSelenium, ' : ''; | ||
| if (warn !== '') { | ||
| logger.warn(warnInto); |
There was a problem hiding this comment.
These two will be on separate lines; is that intentional?
There was a problem hiding this comment.
I could make them a single line.
|
|
||
| let warnInto = 'Using driver provider ' + providerType + ', but also found extra'; | ||
| let warn = ''; | ||
| warn += 'direct' !== providerType && config.directConnect ? 'directConnect: ' : ''; |
There was a problem hiding this comment.
should be 'directConnect, '?
There was a problem hiding this comment.
The driver provider is direct. Probably should call it directConnect.
There was a problem hiding this comment.
No I meant at the end: you have 'directConnect: ' but it should be 'directConnect, '
| export let logWarnings = (providerType: string, config: Config): void => { | ||
|
|
||
| let warnInto = 'Using driver provider ' + providerType + ', but also found extra'; | ||
| let warn = ''; |
There was a problem hiding this comment.
It might make more sense to have this be a string[], and then do a join(', ') at the end. This way you won't get an extra comma
There was a problem hiding this comment.
Sure. I thought about it after I wrote it...
cnishina
force-pushed
the
warn_configparser
branch
2 times, most recently
from
8050720 to
8364545
Compare
- builds the driver provider in lib/driverProviders/index instead of lib/runner closes angular#1945
cnishina
force-pushed
the
warn_configparser
branch
from
8364545 to
c49c6c6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1945