-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tags will not be synced to search plugin when adding new question #696
Comments
@hgaol Thanks for the feedback. This is indeed a bug. It should sync the data of the question to the plugin once again after creating the relation between the question and the tag. |
Thanks @LinkinStars ! I've created a PR to fix this issue. BTW, one thing makes me little confused that which branch should I baded on when working on a feature or bug fix? I'm not sure |
Thank you for your contribution and we will be reviewing it ASAP. The difference between the mai and dev branch is simple: the main branch goes straight to the latest release(v1.2.1), whereas dev goes to the next release(v1.2.5). If we set a milestone(v1.2.5) for this issue to be fixed in the next release, so it's better to start development base on the dev branch. |
#697) fix #696 . changes, 1. change `qr.updateSearch` to `qr.UpdateSearch` to make it accessible outside. 2. update search (search plugin) after updating or adding records in the `TagRel` table. --------- Signed-off-by: Adam Vollrath <[email protected]> Co-authored-by: sy-records <[email protected]> Co-authored-by: Adam Vollrath <[email protected]> Co-authored-by: kumfo <[email protected]>
Describe the bug
when adding a new question, the corresponding tags will not be synced to search plugin because the
TagRel
entities have not been created yet.To Reproduce
Steps to reproduce the behavior:
Expected behavior
question as well as its tags are all synced to search plugin. The root cause is that the
TagRel
entities are not been created yet when updating search.Screenshots
If applicable, add screenshots to help explain your problem.
Platform (please complete the following information):
The text was updated successfully, but these errors were encountered: