Skip to content

fix: tags will not be synced to search plugin when adding new question #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 26, 2023
Merged

fix: tags will not be synced to search plugin when adding new question #697

merged 5 commits into from
Dec 26, 2023

Conversation

hgaol
Copy link
Member

@hgaol hgaol commented Dec 26, 2023 •
edited
Loading

fix #696 .

changes,

  1. change qr.updateSearch to qr.UpdateSearch to make it accessible outside.
  2. update search (search plugin) after updating or adding records in the TagRel table.

@LinkinStars LinkinStars requested a review from kumfo December 26, 2023 04:05
@LinkinStars LinkinStars assigned LinkinStars and kumfo and unassigned LinkinStars Dec 26, 2023
@LinkinStars LinkinStars added this to the v1.2.5 milestone Dec 26, 2023
@LinkinStars LinkinStars changed the base branch from main to dev December 26, 2023 04:12
@hgaol
Copy link
Member Author

hgaol commented Dec 26, 2023

Hi @kumfo , feel free to let me know if any comments. Thanks!

@kumfo
Copy link
Member

kumfo commented Dec 26, 2023

Hi @kumfo , feel free to let me know if any comments. Thanks!

Hi @hgaol , good job! I will merge it after resolve the conflicts.

kumfo
kumfo approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@kumfo kumfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@kumfo kumfo merged commit ec11a12 into apache:dev Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumfo kumfo kumfo approved these changes

Assignees

@kumfo kumfo

Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.

Tags will not be synced to search plugin when adding new question
5 participants
@hgaol @kumfo @LinkinStars @sy-records @axisofentropy