DVO-205: (chore) replace golint

[rluders]

This PR replaces the deprecated golint with revive and fixes some code style issues reported by it.

[openshift-bot]

@rluders: This pull request references DVO-205 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR replaces the deprecated golint with revive and fixes some code style issues reported by it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ncaak]

/lgtm

[rluders]

/retest

[ncaak]

/retest

[rluders]

/retest

[ncaak]

/retest

[ncaak]

/lgtm

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.06%. Comparing base (3eebf29) to head (8ec4d0d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   55.12%   55.06%   -0.07%     
==========================================
  Files          15       15              
  Lines         907      908       +1     
==========================================
  Hits          500      500              
- Misses        377      378       +1     
  Partials       30       30              

Files	Coverage Δ
pkg/prometheus/prometheus.go	22.47% <0.00%> (-0.26%)	⬇️

[ncaak]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ncaak,rluders]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncaak]

/retest