Skip to content

DVO-205: (chore) replace golint #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2024
Merged

DVO-205: (chore) replace golint #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72c5a0
chore: replace golint with revive
Apr 11, 2024
8ec4d0d
style: fix revive reports
Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ linters:
enable:
- gofmt
- goimports
- golint
- revive
- govet
- misspell
- unused
Expand All @@ -18,10 +18,6 @@ linters:
- staticcheck

linters-settings:
golint:
# minimal confidence for issues, default is 0.8
min-confidence: 0

lll:
line-length: 120
tab-width: 8
2 changes: 1 addition & 1 deletion internal/testing/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func (c *TestClient) Create(ctx context.Context, obj client.Object, opts ...Requ
}
}

func (c *TestClient) Update(ctx context.Context, obj client.Object, opts ...RequestOption) {
func (c *TestClient) Update(ctx context.Context, obj client.Object, _ ...RequestOption) {
gomega.ExpectWithOffset(1, c.client.Update(ctx, obj)).Should(gomega.Succeed())
}

Expand Down
1 change: 1 addition & 0 deletions pkg/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ func (s *Server) Start(ctx context.Context) error {
errCh := make(chan error)
drain := func() {
for range errCh {
continue
}
}

Expand Down