Add support to CMake to build swift-argument-parser during SwiftPM bootstrapping #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @compnerd ? |
compnerd
approved these changes
May 11, 2020
CMakeLists.txt
Outdated
|
|
||
| include(CTest) | ||
|
|
||
| if(CMAKE_VERSION VERSION_LESS 3.16 AND CMAKE_SYSTEM_NAME STREQUAL Windows) |
There was a problem hiding this comment.
Is this needed? The minimum for this project is currently 3.16. I think that we can ignore the <3.16 compatibility
There was a problem hiding this comment.
you're right, this was unnecessary, I dropped it
Sources/CMakeLists.txt
Outdated
| @@ -2,3 +2,9 @@ add_subdirectory(ArgumentParser) | |||
| if(BUILD_TESTING) | |||
| add_subdirectory(ArgumentParserTestHelpers) | |||
| endif() | |||
|
|
|||
| set_property(GLOBAL APPEND PROPERTY ARGUMENTPARSER_EXPORTS ArgumentParser) | |||
There was a problem hiding this comment.
Could use ArgumentParser_EXPORTS but, that’s a purely style thing, it has 0 bearing on anything.
There was a problem hiding this comment.
Good to know, I'm not that familiar with CMake style conventions. I updated it since I was already making changes
|
@compnerd thanks for reviewing! |
|
@swift-ci Please test |
|
@owenv my pleasure! |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly early attempt at integrating this repo into the SwiftPM bootstrapped build, someone better at CMake than I am should probably review :)