-
Notifications
You must be signed in to change notification settings - Fork 199
Add a swift-argument-parser dependency and use it in swift-help #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a53c11
to
f00e739
Compare
Tested a cmake build with the change in apple/swift-argument-parser#138 and it seemed to work |
a5b1cde
to
ffd777d
Compare
Good idea! To do this, we'll need to update (or add on to) Swift's list of repos to check out (see swiftlang/swift#31664) and the SwiftPM bootstrap script in swiftlang/swift-package-manager#2736. |
ffd777d
to
58bcb0f
Compare
I'm pulling in swift-argument-parser as a dependency for CI purposes in swiftlang/swift#31664. |
@DougGregor Cool, I hadn't seen that SwiftPM PR! I opened apple/swift-argument-parser#139 to update swift-argument-parser cmake and swiftlang/swift-package-manager#2739 in SwiftPM based on your PR. They probably need a little additional work, but should be mostly on the right track. |
@owenv This is great! Merged your PR in the argument parser. We'll want to follow up later to add support for querying help for the other swift tools using |
I think this is great! Now that the integrated driver is merged into SwiftPM, there are a few steps needed to make this work out:
... and then we can merge this |
@DougGregor I've tagged an 0.0.6 release for swift-argument-parser that includes @owenv's CMake fixes. |
58bcb0f
to
285c4ed
Compare
Thanks @natecook1000, I'll switch update-checkout to start using the new tag and then we should be all set to adopt ArgumentParser! |
@owenv apparently the source compatibility suite has another copy of the update-checkout information that will also need updating (ugh) |
@DougGregor Thanks for the heads up, I had no idea that had its own config. I just saw this commit: swiftlang/swift-source-compat-suite@8d478f0 , I'll copy that |
285c4ed
to
d2c5c27
Compare
5647a32
to
cda48e6
Compare
This is up-and-running with swift-argument-parser 0.3.0 now. The current plan is
|
cda48e6
to
1f0a62a
Compare
@swift-ci test |
Once the tests at swiftlang/swift-package-manager#2739 pass, we should be able to merge this 🎉 |
@swift-ci test |
swift-argument-parser needs some CMake fixes before this can land