Skip to content

Fix incorrect bootloader version check #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2020
Merged

Fix incorrect bootloader version check #69

merged 5 commits into from
Oct 12, 2020

Conversation

sebromero
Copy link
Collaborator

The bootloader updater sketch didn't dynamically check for an updated version. This PR fixes that plus improves the clarity and understandability of the bootloader information.

@sebromero sebromero requested a review from facchinm October 10, 2020 11:08
@github-actions
Copy link

Memory usage change @ f7c8f58

Board flash % RAM for global variables %
arduino-beta:mbed:envie_m4 ❔ -48 - +952 -0.0 - +0.09 0 - 0 0.0 - 0.0
arduino-beta:mbed:envie_m7 ❔ -48 - +960 -0.01 - +0.12 🔺 0 - +8 0.0 - 0.0
arduino-beta:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino-beta:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -48 -0.0 0 0.0 952 0.09 0 0.0 0 0.0 0 0.0
arduino-beta:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -48 -0.01 0 0.0 960 0.12 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino-beta:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino-beta:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-48,-0.0,0,0.0,952,0.09,0,0.0,0,0.0,0,0.0
arduino-beta:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-48,-0.01,0,0.0,960,0.12,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino-beta:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,0,0.0,0,0.0

@github-actions
Copy link

Memory usage change @ a7f758c

Board flash % RAM for global variables %
arduino-beta:mbed:envie_m4 ❔ -48 - +952 -0.0 - +0.09 0 - 0 0.0 - 0.0
arduino-beta:mbed:envie_m7 ❔ -48 - +960 -0.01 - +0.12 🔺 0 - +8 0.0 - 0.0
arduino-beta:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino-beta:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -48 -0.0 0 0.0 952 0.09 0 0.0 0 0.0 0 0.0
arduino-beta:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 -48 -0.01 0 0.0 960 0.12 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino-beta:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino-beta:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-48,-0.0,0,0.0,952,0.09,0,0.0,0,0.0,0,0.0
arduino-beta:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-48,-0.01,0,0.0,960,0.12,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino-beta:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,0,0.0,0,0.0

@facchinm facchinm merged commit 135c959 into master Oct 12, 2020
@sebromero sebromero deleted the bootloader-info-update branch October 12, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebromero @facchinm