-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid HELM option in usage docs #374
Fix invalid HELM option in usage docs #374
Conversation
clean blank space
@brudnyhenry Don't forget to sign the CLA so we can review and accept your contributions! 😄 |
Codecov Report
@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 77.64% 77.64%
=======================================
Files 22 22
Lines 1011 1011
=======================================
Hits 785 785
Misses 142 142
Partials 84 84 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks
@brudnyhenry Can you rebase this PR so we can merge it in? Thanks! 😄 |
Description
Fix usage documentation with valid helm template flag
--include-crds
https://helm.sh/docs/helm/helm_template/
Fixes: #373
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17
to ensure only the minimum is pulled in.Type of Change
Other information