Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid HELM option in usage docs #374

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

brudnyhenry
Copy link
Contributor

Description

Fix usage documentation with valid helm template flag --include-crds
https://helm.sh/docs/helm/helm_template/
Fixes: #373

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2022

CLA assistant check
All committers have signed the CLA.

clean blank space
@werne2j
Copy link
Member

werne2j commented Jul 12, 2022

@brudnyhenry Don't forget to sign the CLA so we can review and accept your contributions! 😄

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #374 (1092d00) into main (8ed2581) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #374   +/-   ##
=======================================
  Coverage   77.64%   77.64%           
=======================================
  Files          22       22           
  Lines        1011     1011           
=======================================
  Hits          785      785           
  Misses        142      142           
  Partials       84       84           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks

@werne2j
Copy link
Member

werne2j commented Jul 18, 2022

@brudnyhenry Can you rebase this PR so we can merge it in? Thanks! 😄

@werne2j werne2j merged commit 784da57 into argoproj-labs:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants