Skip to content

Fix invalid HELM option in usage docs #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Fix invalid HELM option in usage docs #374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14cb699
Fix invalid HELM option in usage docs
brudnyhenry Jul 12, 2022
96f393b
Update usage.md
brudnyhenry Jul 12, 2022
1092d00
Merge branch 'main' into fix/docs-usage-helm-template
brudnyhenry Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ configManagementPlugins: |
args: ["helm dependency build"]
generate:
command: ["sh", "-c"]
args: ["helm template $ARGOCD_APP_NAME . --install-crds | argocd-vault-plugin generate -"]
args: ["helm template $ARGOCD_APP_NAME . --include-crds | argocd-vault-plugin generate -"]
```
For sidecar configured plugins, add this to `cmp-plugin` ConfigMap, and then [add a sidecar to run it](../installation#initcontainer-and-configuration-via-sidecar):
```yaml
Expand All @@ -73,7 +73,7 @@ For sidecar configured plugins, add this to `cmp-plugin` ConfigMap, and then [ad
- sh
- "-c"
- |
helm template $ARGOCD_APP_NAME --install-crds . |
helm template $ARGOCD_APP_NAME --include-crds . |
argocd-vault-plugin generate -
lockRepo: false
```
Expand All @@ -90,7 +90,7 @@ configManagementPlugins: |
args: ["helm dependency build"]
generate:
command: ["sh", "-c"]
args: ["helm template $ARGOCD_APP_NAME ${helm_args} . --install-crds | argocd-vault-plugin generate -"]
args: ["helm template $ARGOCD_APP_NAME ${helm_args} . --include-crds | argocd-vault-plugin generate -"]
```
For sidecar configured plugins, add this to `cmp-plugin` ConfigMap, and then [add a sidecar to run it](../installation#initcontainer-and-configuration-via-sidecar):
```yaml
Expand All @@ -113,7 +113,7 @@ For sidecar configured plugins, add this to `cmp-plugin` ConfigMap, and then [ad
- sh
- "-c"
- |
helm template $ARGOCD_APP_NAME --install-crds -n $ARGOCD_APP_NAMESPACE ${ARGOCD_ENV_HELM_ARGS} . |
helm template $ARGOCD_APP_NAME --include-crds -n $ARGOCD_APP_NAMESPACE ${ARGOCD_ENV_HELM_ARGS} . |
argocd-vault-plugin generate -
lockRepo: false
```
Expand Down Expand Up @@ -289,4 +289,4 @@ As mentioned in the [Installation page](../installation), Argo CD has a newer me

- Using `github` URLs (`github.com/*`) with Kustomize requires having `git` in the container, and will fail otherwise. Use a `raw.githubusercontent.com` URL as a workaround if installing `git` isn't an option

- The `argocd-repo-server` container has a default limit, configuration key named `server.repo.server.timeout.seconds` in `argocd-cm` ConfigMap, of 60 seconds - this may need to be increased if lots of placeholders have to be processed for a given Application. The sidecar also has a default timeout, environment variable named `ARGOCD_EXEC_TIMEOUT` in the sidecar, of 90 seconds. This may also need to be increased. Details here: <https://argo-cd.readthedocs.io/en/stable/user-guide/config-management-plugins/#using-a-cmp>
- The `argocd-repo-server` container has a default limit, configuration key named `server.repo.server.timeout.seconds` in `argocd-cm` ConfigMap, of 60 seconds - this may need to be increased if lots of placeholders have to be processed for a given Application. The sidecar also has a default timeout, environment variable named `ARGOCD_EXEC_TIMEOUT` in the sidecar, of 90 seconds. This may also need to be increased. Details here: <https://argo-cd.readthedocs.io/en/stable/user-guide/config-management-plugins/#using-a-cmp>