Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ARGOCD_ENV prefix in the helm with args example #431

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

kroustou
Copy link
Contributor

@kroustou kroustou commented Nov 10, 2022

Description

The example that shows how avp can be invoked to render with the cm configmap has been updated to:

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2022

CLA assistant check
All committers have signed the CLA.

@kroustou kroustou marked this pull request as ready for review November 10, 2022 15:31
The example that shows how avp can be invoked to render with the cm configmap has been updated to:
- include the prefix argo appends (ARGOCD_ENV)
- respect the applications namespace

Signed-off-by: Stavros Kroustouris <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #431 (4a5deb8) into main (a71224e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files          23       23           
  Lines        1485     1485           
=======================================
  Hits         1146     1146           
  Misses        252      252           
  Partials       87       87           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@werne2j werne2j merged commit 9eabb45 into argoproj-labs:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants