Add support for Delinea Secret Server #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
GerbenWelter
force-pushed
the
feature/add_delinea_secret_server
branch
2 times, most recently
from
5c5376a to
ced8be9
Compare
|
@GerbenWelter Can you update your branch and resolve conflicts? |
14 tasks
GerbenWelter
force-pushed
the
feature/add_delinea_secret_server
branch
from
ced8be9 to
989a4f3
Compare
Signed-off-by: Gerben Welter <[email protected]>
GerbenWelter
force-pushed
the
feature/add_delinea_secret_server
branch
from
989a4f3 to
4d28244
Compare
|
@werne2j done. |
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 77.55% 75.31% -2.25%
==========================================
Files 24 25 +1
Lines 1613 1689 +76
==========================================
+ Hits 1251 1272 +21
- Misses 269 323 +54
- Partials 93 94 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
werne2j
approved these changes
Apr 1, 2023
There was a problem hiding this comment.
Thanks @GerbenWelter! Not familiar with Delinea but the code looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Delinea Secret Server (formerly known as Thycotic Secret Server)
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17to ensure only the minimum is pulled in.Type of Change
Other information
This PR is largely a rebase of #428. Many thanks to @fdammeke for providing it. Because the PR looked stale and needed a rebase I made this PR with the following changes:
Also #428 provided tests for getting secrets but it was using a local Secret Server to pass the tests. Unfortunately the Delinea SDK doesn't seem to have provisionings for mock testing requests.
I do have added tests for the configuration validation.
The
argocd-vault-pluginbinary has been tested with an on-premise Delinea Secret Server.