Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for argocd admin export command to validate behaviour #22391

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nitishfy
Copy link
Member

@nitishfy nitishfy commented Mar 18, 2025

Completes 1st part of #21895
(The import command code needs a lot of refactoring so I thought it's best to raise those tests in another PR to avoid difficulty in the review process)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Mar 18, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@nitishfy nitishfy changed the title [WIP] test: add unit tests for export and import command to validate behaviour test: add unit tests for export and import command to validate behaviour Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 167 lines in your changes missing coverage. Please review.

Project coverage is 55.87%. Comparing base (fe347e3) to head (3267631).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/admin/backup.go 0.00% 167 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22391      +/-   ##
==========================================
- Coverage   55.88%   55.87%   -0.01%     
==========================================
  Files         343      343              
  Lines       57333    57382      +49     
==========================================
+ Hits        32042    32065      +23     
- Misses      22644    22670      +26     
  Partials     2647     2647              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nitishfy nitishfy force-pushed the nitish/unit-tests branch 2 times, most recently from 3267631 to cd80563 Compare March 25, 2025 07:28
@nitishfy nitishfy changed the title test: add unit tests for export and import command to validate behaviour test: add unit tests for argocd admin export command to validate behaviour Mar 25, 2025
@nitishfy nitishfy marked this pull request as ready for review March 25, 2025 07:30
@nitishfy nitishfy requested a review from a team as a code owner March 25, 2025 07:30
var writer io.Writer
var cleanup func()

if out == "-" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of passing in a string "out", should the user of these functions pass in an io.Writer? This function also wouldn't need to have any cleanup logic then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants