-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit tests for argocd admin export
command to validate behaviour
#22391
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
export
and import
command to validate behaviourexport
and import
command to validate behaviour
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22391 +/- ##
==========================================
- Coverage 55.88% 55.87% -0.01%
==========================================
Files 343 343
Lines 57333 57382 +49
==========================================
+ Hits 32042 32065 +23
- Misses 22644 22670 +26
Partials 2647 2647 ☔ View full report in Codecov by Sentry. |
Signed-off-by: nitishfy <[email protected]>
Signed-off-by: nitishfy <[email protected]>
3267631
to
cd80563
Compare
export
and import
command to validate behaviourargocd admin export
command to validate behaviour
var writer io.Writer | ||
var cleanup func() | ||
|
||
if out == "-" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing in a string "out", should the user of these functions pass in an io.Writer
? This function also wouldn't need to have any cleanup logic then.
Completes 1st part of #21895
(The
import
command code needs a lot of refactoring so I thought it's best to raise those tests in another PR to avoid difficulty in the review process)Checklist: