test: add unit tests for argocd admin export command to validate behaviour

cmd/argocd/commands/admin/backup_test.go

@@ -1,8 +1,16 @@
 package admin
 
 import (
+	"bufio"
+	"io"
+	"os"
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
+	"github.com/argoproj/argo-cd/v3/pkg/apis/application/v1alpha1"
+	"github.com/argoproj/argo-cd/v3/util/security"
+
 	"github.com/argoproj/gitops-engine/pkg/utils/kube"
 	"github.com/stretchr/testify/assert"
 	corev1 "k8s.io/api/core/v1"
@@ -12,6 +20,32 @@ import (
 	"github.com/argoproj/argo-cd/v3/common"
 )
 
+func createTestWriter(t *testing.T, out string) (io.Writer, func()) {
+	t.Helper()
+
+	var writer io.Writer
+	var cleanup func()
+
+	if out == "-" {
+		writer = os.Stdout
+		cleanup = func() {}
+	} else {
+		f, err := os.Create(out)
+		require.NoError(t, err)
+
+		bw := bufio.NewWriter(f)
+		writer = bw
+
+		cleanup = func() {
+			require.NoError(t, bw.Flush())
+			require.NoError(t, f.Close())
+			_ = os.Remove(out)
+		}
+	}
+
+	return writer, cleanup
+}
+
 func newBackupObject(trackingValue string, trackingLabel bool, trackingAnnotation bool) *unstructured.Unstructured {
 	cm := corev1.ConfigMap{
 		ObjectMeta: metav1.ObjectMeta{
@@ -35,6 +69,343 @@ func newBackupObject(trackingValue string, trackingLabel bool, trackingAnnotatio
 	return kube.MustToUnstructured(&cm)
 }
 
+func newConfigmapObject() *unstructured.Unstructured {
+	cm := corev1.ConfigMap{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      common.ArgoCDConfigMapName,
+			Namespace: "argocd",
+			Labels: map[string]string{
+				"app.kubernetes.io/part-of": "argocd",
+			},
+		},
+	}
+
+	return kube.MustToUnstructured(&cm)
+}
+
+func newSecretsObject() *unstructured.Unstructured {
+	secret := corev1.Secret{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      common.ArgoCDSecretName,
+			Namespace: "default",
+			Labels: map[string]string{
+				"app.kubernetes.io/part-of": "argocd",
+			},
+		},
+		Data: map[string][]byte{
+			"admin.password":   nil,
+			"server.secretkey": nil,
+		},
+	}
+
+	return kube.MustToUnstructured(&secret)
+}
+
+func newAppProject() *unstructured.Unstructured {
+	appProject := v1alpha1.AppProject{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "default",
+			Namespace: "argocd",
+		},
+		Spec: v1alpha1.AppProjectSpec{
+			Destinations: []v1alpha1.ApplicationDestination{
+				{
+					Namespace: "*",
+					Server:    "*",
+				},
+			},
+			ClusterResourceWhitelist: []metav1.GroupKind{
+				{
+					Group: "*",
+					Kind:  "*",
+				},
+			},
+			SourceRepos: []string{"*"},
+		},
+	}
+
+	return kube.MustToUnstructured(&appProject)
+}
+
+func newApplication(namespace string) *unstructured.Unstructured {
+	app := v1alpha1.Application{
+		TypeMeta: metav1.TypeMeta{
+			Kind: "Application",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "test",
+			Namespace: namespace,
+		},
+		Spec: v1alpha1.ApplicationSpec{
+			Source:  &v1alpha1.ApplicationSource{},
+			Project: "default",
+			Destination: v1alpha1.ApplicationDestination{
+				Server:    v1alpha1.KubernetesInternalAPIServerAddr,
+				Namespace: "default",
+			},
+		},
+	}
+
+	return kube.MustToUnstructured(&app)
+}
+
+func newApplicationSet(namespace string) *unstructured.Unstructured {
+	appSet := v1alpha1.ApplicationSet{
+		TypeMeta: metav1.TypeMeta{
+			Kind: "ApplicationSet",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "test-appset",
+			Namespace: namespace,
+		},
+		Spec: v1alpha1.ApplicationSetSpec{
+			Generators: []v1alpha1.ApplicationSetGenerator{
+				{
+					Git: &v1alpha1.GitGenerator{
+						RepoURL: "https://github.com/org/repo",
+					},
+				},
+			},
+		},
+	}
+
+	return kube.MustToUnstructured(&appSet)
+}
+
+// Test_exportResources tests for the resources exported when using the `argocd admin export` command
+func Test_exportResources(t *testing.T) {
+	tests := []struct {
+		name                string
+		object              *unstructured.Unstructured
+		out                 string
+		namespace           string
+		enabledNamespaces   []string
+		expectedFileContent string
+		expectExport        bool
+	}{
+		{
+			name:         "ConfigMap should be in the exported manifest",
+			object:       newConfigmapObject(),
+			out:          "test.yaml",
+			expectExport: true,
+			expectedFileContent: `apiVersion: ""
+kind: ""
+metadata:
+  labels:
+    app.kubernetes.io/part-of: argocd
+  name: argocd-cm
+---
+`,
+		},
+		{
+			name:         "Secret should be in the exported manifest",
+			object:       newSecretsObject(),
+			out:          "test.yaml",
+			expectExport: true,
+			expectedFileContent: `apiVersion: ""
+data:
+  admin.password: null
+  server.secretkey: null
+kind: ""
+metadata:
+  labels:
+    app.kubernetes.io/part-of: argocd
+  name: argocd-secret
+  namespace: default
+---
+`,
+		},
+		{
+			name:         "App Project should be in the exported manifest",
+			object:       newAppProject(),
+			out:          "test.yaml",
+			expectExport: true,
+			expectedFileContent: `apiVersion: ""
+kind: ""
+metadata:
+  name: default
+spec:
+  clusterResourceWhitelist:
+  - group: '*'
+    kind: '*'
+  destinations:
+  - namespace: '*'
+    server: '*'
+  sourceRepos:
+  - '*'
+status: {}
+---
+`,
+		},
+		{
+			name:         "Application should be in the exported manifest when created in the default 'argocd' namespace",
+			object:       newApplication("argocd"),
+			out:          "test.yaml",
+			namespace:    "argocd",
+			expectExport: true,
+			expectedFileContent: `apiVersion: ""
+kind: Application
+metadata:
+  name: test
+spec:
+  destination:
+    namespace: default
+    server: https://kubernetes.default.svc
+  project: default
+  source:
+    repoURL: ""
+status:
+  health: {}
+  sourceHydrator: {}
+  summary: {}
+  sync:
+    comparedTo:
+      destination: {}
+      source:
+        repoURL: ""
+    status: ""
+---
+`,
+		},
+		{
+			name:              "Application should be in the exported manifest when created in the enabled namespaces",
+			object:            newApplication("dev"),
+			out:               "test.yaml",
+			namespace:         "dev",
+			enabledNamespaces: []string{"dev", "prod"},
+			expectExport:      true,
+			expectedFileContent: `apiVersion: ""
+kind: Application
+metadata:
+  name: test
+  namespace: dev
+spec:
+  destination:
+    namespace: default
+    server: https://kubernetes.default.svc
+  project: default
+  source:
+    repoURL: ""
+status:
+  health: {}
+  sourceHydrator: {}
+  summary: {}
+  sync:
+    comparedTo:
+      destination: {}
+      source:
+        repoURL: ""
+    status: ""
+---
+`,
+		},
+		{
+			name:                "Application should not be in the exported manifest when it's neither created in the default argod namespace nor in enabled namespace",
+			object:              newApplication("staging"),
+			out:                 "test.yaml",
+			namespace:           "stagin",
+			enabledNamespaces:   []string{"dev", "prod"},
+			expectExport:        false,
+			expectedFileContent: ``,
+		},
+		{
+			name:         "ApplicationSet should be in the exported manifest when created in the default 'argocd' namespace",
+			object:       newApplicationSet("argocd"),
+			out:          "test.yaml",
+			namespace:    "argocd",
+			expectExport: true,
+			expectedFileContent: `apiVersion: ""
+kind: ApplicationSet
+metadata:
+  name: test-appset
+spec:
+  generators:
+  - git:
+      repoURL: https://github.com/org/repo
+      revision: ""
+      template:
+        metadata: {}
+        spec:
+          destination: {}
+          project: ""
+  template:
+    metadata: {}
+    spec:
+      destination: {}
+      project: ""
+status: {}
+---
+`,
+		},
+		{
+			name:              "ApplicationSet should be in the exported manifest when created in the enabled namespaces",
+			object:            newApplicationSet("dev"),
+			out:               "test.yaml",
+			namespace:         "dev",
+			enabledNamespaces: []string{"dev", "prod"},
+			expectExport:      true,
+			expectedFileContent: `apiVersion: ""
+kind: ApplicationSet
+metadata:
+  name: test-appset
+  namespace: dev
+spec:
+  generators:
+  - git:
+      repoURL: https://github.com/org/repo
+      revision: ""
+      template:
+        metadata: {}
+        spec:
+          destination: {}
+          project: ""
+  template:
+    metadata: {}
+    spec:
+      destination: {}
+      project: ""
+status: {}
+---
+`,
+		},
+		{
+			name:                "ApplicationSet should not be in the exported manifest when neither created in the default 'argocd' namespace nor in enabled namespaces",
+			object:              newApplicationSet("staging"),
+			out:                 "test.yaml",
+			namespace:           "staging",
+			enabledNamespaces:   []string{"dev", "prod"},
+			expectExport:        false,
+			expectedFileContent: ``,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			w, cleanup := createTestWriter(t, tt.out)
+			kind := tt.object.GetKind()
+			if kind == "Application" || kind == "ApplicationSet" {
+				if security.IsNamespaceEnabled(tt.namespace, "argocd", tt.enabledNamespaces) {
+					export(w, *tt.object, ArgoCDNamespace)
+				}
+			} else {
+				export(w, *tt.object, ArgoCDNamespace)
+			}
+
+			if bw, ok := w.(*bufio.Writer); ok {
+				require.NoError(t, bw.Flush())
+			}
+			content, err := os.ReadFile(tt.out)
+			require.NoError(t, err)
+			if tt.expectExport {
+				assert.Equal(t, tt.expectedFileContent, string(content))
+			} else {
+				assert.Empty(t, string(content))
+			}
+			cleanup()
+		})
+	}
+}
+
 func Test_updateTracking(t *testing.T) {
 	type args struct {
 		bak  *unstructured.Unstructured