made ICompilerSettings and CSharpCodeProvider ctor public #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CodeProvider also public
|
|
|
@trullock The original goal for this package is to enable asp.net to leverage Roslyn compilers for dynamical compilation. In that context, it doesn't make sense to expose the non-default-constructor, since asp.net only uses default constructor. |
Jinhuafei
reviewed
Jul 9, 2018
| @@ -4,7 +4,7 @@ | |||
| using System; | |||
|
|
|||
| namespace Microsoft.CodeDom.Providers.DotNetCompilerPlatform { | |||
| internal interface ICompilerSettings { | |||
| public interface ICompilerSettings { | |||
There was a problem hiding this comment.
Can you please add some comments?
| @@ -18,8 +18,12 @@ public CSharpCodeProvider() | |||
| : this(null) { | |||
| } | |||
|
|
|||
| // Constructor used for unit test purpose | |||
| internal CSharpCodeProvider(ICompilerSettings compilerSettings = null) { | |||
|
|
|||
There was a problem hiding this comment.
Can you please also update VBCodeProvider?
|
Excellent. Can we get a 2.0.1 nuget of this soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its unclear why CompilationSettings doesn't allow falling back to the tooling installed on the dev environment, or to use a csc compiler from a different location that whats shipped with this assembly.
By making the ICompilerSettings interface public this becomes trivial.
I don't see any reason for this to be internal