Skip to content

made CompilerSettings public #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

made CompilerSettings public #63

wants to merge 1 commit into from

Conversation

trullock
Copy link
Contributor

Modification to #55, feels like we should have made this public too

@Jinhuafei Jinhuafei mentioned this pull request Oct 2, 2018
Closed
@twsouthwick twsouthwick mentioned this pull request Aug 28, 2019
Closed
@StephenMolloy
Copy link
Contributor

StephenMolloy commented Apr 28, 2020 •
edited
Loading

In a shift to allow more configurability through <providerOptions>, the *CompilerSettings pattern is being obsoleted in favor of *ProviderOptions. PR #102 has all these changes, including making both IProviderOptions and ProviderOptions public, so this PR won't be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trullock @StephenMolloy