Skip to content

Add general rule tests #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sindresorhus opened this issue May 4, 2019 · 3 comments · Fixed by #246
Closed

Add general rule tests #242

sindresorhus opened this issue May 4, 2019 · 3 comments · Fixed by #246

Comments

@sindresorhus
Copy link
Member

Like: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/test/package.js Can probably just borrow those directly.

@rahgurung
Copy link
Contributor

@sindresorhus assertion-message is deprecated but why the rule is still there? We need to add back the docs and tests to make the tests pass. Another problem i faced is no-ignored-test-files is rule which have two tests in different files like no-ignored-test-files-with-package and no-ignored-test-files-without-package, I should merge them ?

@sindresorhus
Copy link
Member Author

assertion-message is deprecated but why the rule is still there?

Graceful removal. We can remove it now though.

Another problem i faced is no-ignored-test-files is rule which have two tests in different files like no-ignored-test-files-with-package and no-ignored-test-files-without-package, I should merge them ?

I would just add a manual ignore check for those.

@sindresorhus
Copy link
Member Author

Graceful removal. We can remove it now though.

Removed

rahgurung added a commit to rahgurung/eslint-plugin-ava that referenced this issue May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants