Skip to content

Add tests to enforce some rule guidelines #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2019
Merged

Conversation

rahgurung
Copy link
Contributor

Fixes #242

@GMartigny
Copy link
Contributor

Looks good to me

@sindresorhus
Copy link
Member

Can you fix the merge conflict?

@sindresorhus sindresorhus changed the title #242 - added general rule tests Add tests to enforce some rule guidelines May 25, 2019
@rahgurung
Copy link
Contributor Author

@sindresorhus done.

@sindresorhus
Copy link
Member

You didn't resolve the merge conflict correctly. Look at the diff. Many unrelated changes.

@rahgurung
Copy link
Contributor Author

@sindresorhus good to go.

@sindresorhus
Copy link
Member

You still have unrelated changes. Please look at the diff carefully.

@rahgurung
Copy link
Contributor Author

Hey, I double checked and couldn't find any unrelated changes, can you point to it, please.

@rahgurung
Copy link
Contributor Author

@sindresorhus good to go?

@sindresorhus sindresorhus merged commit b1f34a0 into avajs:master May 26, 2019
@sindresorhus
Copy link
Member

Yup. Thank you :)

@rahgurung rahgurung deleted the 242 branch May 26, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add general rule tests
3 participants