Ignore DomainValidationOptions and keyAlgorithm deltaCompare #57
Conversation
michaelhtm
force-pushed
the
customcompare/dvo
branch
from
eeb98b7 to
112426f
Compare
| @@ -102,6 +104,9 @@ resources: | |||
| from: | |||
| operation: DescribeCertificate | |||
| path: Certificate.DomainValidationOptions | |||
| DomainValidationOptions: | |||
There was a problem hiding this comment.
Are these fields used during Create only?
There was a problem hiding this comment.
yes..and they are also returned with describe...
There was a problem hiding this comment.
Does it make sense to make them immutable instead?
michaelhtm
changed the title
michaelhtm
changed the title
The DomainValidationOptions are returned with arbitrary order. Removing comparison completely since there is no update operation to change it. Same goes for keyAlgorithm
michaelhtm
force-pushed
the
customcompare/dvo
branch
from
112426f to
26eeb04
Compare
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #2395
Description of changes:
The DomainValidationOptions are returned with arbitrary order. Removing
comparison completely since there is no update operation to change it.
Same goes for keyAlgorithm
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.