Skip to content

Ignore DomainValidationOptions and keyAlgorithm deltaCompare #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

Ignore DomainValidationOptions and keyAlgorithm deltaCompare #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
642e184
Ignore DomainValidationOptions and keyAlgorithm deltaCompare
michaelhtm Mar 25, 2025
26eeb04
Make fields and immutable
michaelhtm Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-03-27T16:36:43Z"
build_date: "2025-04-03T18:41:21Z"
build_hash: 980cb1e4734f673d16101cf55206b84ca639ec01
go_version: go1.24.1
version: v0.44.0
api_directory_checksum: 06c3fd0ed69ec69d489b2ca1582a2b21caaf2ad5
api_directory_checksum: c81e9094002706a6f7db72617aa0348cb7e53dd5
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: 38b3144fc024675b7bdccb9141fc36779effb946
file_checksum: 1489a54e7f1a1b28f8b44e738c239b03b364f74a
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/certificate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ resources:
is_immutable: true
KeyAlgorithm:
late_initialize: {}
is_immutable: true
compare:
is_ignored: true
Options:
late_initialize: {}
# NOTE(jaypipes): The Create operation (RequestCertificate) has a
Expand All @@ -102,6 +105,10 @@ resources:
from:
operation: DescribeCertificate
path: Certificate.DomainValidationOptions
DomainValidationOptions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these fields used during Create only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes..and they are also returned with describe...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to make them immutable instead?

is_immutable: true
compare:
is_ignored: true
ExtendedKeyUsages:
is_read_only: true
from:
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/acm.services.k8s.aws_certificates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ spec:
type: string
type: object
type: array
x-kubernetes-validations:
- message: Value is immutable once set
rule: self == oldSelf
keyAlgorithm:
description: |-
Specifies the algorithm of the public and private key pair that your certificate
Expand Down Expand Up @@ -181,6 +184,9 @@ spec:

Default: RSA_2048
type: string
x-kubernetes-validations:
- message: Value is immutable once set
rule: self == oldSelf
options:
description: |-
Currently, you can use this parameter to specify whether to add the certificate
Expand Down
7 changes: 7 additions & 0 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ resources:
is_immutable: true
KeyAlgorithm:
late_initialize: {}
is_immutable: true
compare:
is_ignored: true
Options:
late_initialize: {}
# NOTE(jaypipes): The Create operation (RequestCertificate) has a
Expand All @@ -102,6 +105,10 @@ resources:
from:
operation: DescribeCertificate
path: Certificate.DomainValidationOptions
DomainValidationOptions:
is_immutable: true
compare:
is_ignored: true
ExtendedKeyUsages:
is_read_only: true
from:
Expand Down
6 changes: 6 additions & 0 deletions helm/crds/acm.services.k8s.aws_certificates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ spec:
type: string
type: object
type: array
x-kubernetes-validations:
- message: Value is immutable once set
rule: self == oldSelf
keyAlgorithm:
description: |-
Specifies the algorithm of the public and private key pair that your certificate
Expand Down Expand Up @@ -181,6 +184,9 @@ spec:

Default: RSA_2048
type: string
x-kubernetes-validations:
- message: Value is immutable once set
rule: self == oldSelf
options:
description: |-
Currently, you can use this parameter to specify whether to add the certificate
Expand Down
14 changes: 0 additions & 14 deletions pkg/resource/certificate/delta.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.