Support for TransitGatewayAttachment resource

[mattzech]

What is the URL of the document?

Go docs

Also, ACK tutorials

Which section(s) is the issue in?

TransitGateway creation in the VPC tutorial

What needs fixing?

It is very unclear how to attach a TransitGateway to a subnet/vpc using a TransitGatewayAttachment. Since the TGA resource is not an object, it cannot be created in the same way as a TransitGateway in Golang. This doc request is also a question of how this is supposed to be handled.

Additional context

I am wondering what resources are required in order to properly attach a Transit Gateway to a VPC. I am also wondering if there is a reason the TransitGatewayAttachment is not an object in Go.

Thanks!

[a-hilaly]

/cc @aws-controllers-k8s/ec2-maintainer

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[laiminhtrung1997]

Is there any news on this? How can I create Transit Gateway Attachment with ACK?

[ack-bot]

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

[a-hilaly]

For the ec2 controller we have documentation for all the supported resources here, PTAL https://aws-controllers-k8s.github.io/community/reference/ec2/v1alpha1/transitgateway/

[jlbutler]

This issue was tracking docs gap, but we need a resource for TransitGatewayAttachment

[michaelhtm]

Hello! After looking into this further, Would it be a better UX to not create a new resource, but instead define which VPCs you would want to attach to a transitGateway?
This would mean we would add a new field, maybe name it attachments. Here's an example:

apiVersion: ec2.services.k8s.aws/v1alpha1
kind: TransitGateway
metadata:
  name: $TGW_NAME
spec:
  attachments:
  - vpcID: $VPC_ID
    options:
      applianceModeSupport: enable
      dnsSupport: enable
      ipv6Support: enable
      dnsSupport: enable
      securityGroupReferencingSupport: enable
    subnetIDs:
    - $SUBNET_ID
  tags:
    - key: $TAG_KEY
      value: $TAG_VALUE

The drawbacks of this solution would be, you can't tag a specific transitgateway attachment..
but on the plus side, there would be less resources to manage..

cc: @jas-nik @laiminhtrung1997 @mattzech @jlbutler @a-hilaly @rushmash91