Skip to content

feat: new resource - TransitGatewayVPCAttachment #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

feat: new resource - TransitGatewayVPCAttachment #251

merged 3 commits into from
Mar 28, 2025

Conversation

michaelhtm
Copy link
Member

Issue #1865

Description of changes:
With these changes we are supporting TransitGatewayVPCAttachment resources.
This resource can reference TrasitGatewayID, VPCID, and SubnetID by their resource
name. Also adding e2e tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler March 25, 2025 20:00
@ack-prow ack-prow bot added the approved label Mar 25, 2025
@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch 7 times, most recently from 5c803a6 to b53b511 Compare March 26, 2025 17:56
@michaelhtm
Copy link
Member Author

/test ec2-kind-e2e

@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch 3 times, most recently from d08682a to 92c4908 Compare March 27, 2025 03:22
@michaelhtm
Add support for TransitGatewayVPCAttachment resource
40a483f 
With these changes we are supporting TransitGatewayVPCAttachment
resources. This resource can reference TrasitGatewayID, VPCID, and
SubnetID by their resource name. Also adding e2e tests.
@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch from 92c4908 to 8368073 Compare March 27, 2025 03:31
@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch 2 times, most recently from ef5aa45 to 09ab52f Compare March 27, 2025 19:15
a-hilaly
a-hilaly reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch 7 times, most recently from 3e935a8 to c98262a Compare March 28, 2025 16:31
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm michaelhtm changed the title Add support for TransitGatewayVPCAttachment resource feat: new resource - TransitGatewayVPCAttachment Mar 28, 2025
@michaelhtm
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member Author

/retest

a-hilaly
a-hilaly reviewed Mar 28, 2025
View reviewed changes
@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch from c98262a to b1bdd14 Compare March 28, 2025 19:32
@michaelhtm
Combine tests into one function
3e7a541 
Doing so becasue there can only be one VPC attachment at a time
and the resource stays in deleting for several minutes.
@michaelhtm michaelhtm force-pushed the newResource/TransitGatewayVPCAttachment branch from b1bdd14 to 3e7a541 Compare March 28, 2025 20:20
a-hilaly
a-hilaly approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member

Thanks @michaelhtm !

@michaelhtm
Copy link
Member Author

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Mar 28, 2025 •
edited
Loading

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-verify-attribution 3e7a541 link false /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ack-prow ack-prow bot merged commit 25c4b4b into aws-controllers-k8s:main Mar 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@a-hilaly a-hilaly

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelhtm @a-hilaly