Skip to content

make tableReplica a no-op field #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

rushmash91
Copy link
Member

@rushmash91 rushmash91 commented Mar 27, 2025

Previously, we released a new patch version of dynamodb that introduced a new field called tableReplicas.

It turns out that updating to this change could trigger accidental deletion of table replicas that were previously/manually created or managed with different tools (such as CDK/CF). To smoothen the upgrade process, we propose to revert this change in a patch release, and re-introduce tableReplicas in a minor one, aligning more with semantic versioning standards and signaling to ACK users that a significant feature has been introduced so that they can read the change log and take the necessary actions.

We also propose that we create a standard/process around versioning, ideally new fields needs to be introduced in minor releases, patches should only include bug fixes and non-break behavior changes.

Description of changes:

  • removing tableReplica hooks , will be included with a minor release.
  • tableReplica field remains as a no-op field

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm March 27, 2025 17:39
@ack-prow ack-prow bot added the approved label Mar 27, 2025
Copy link

ack-prow bot commented Mar 27, 2025

@rushmash91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
dynamodb-verify-attribution d5fe7bc link false /test dynamodb-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91 rushmash91 changed the title sdkDelete does not delete replicas make tableReplica a no-op field Mar 27, 2025
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
Copy link

ack-prow bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 099dbf8 into aws-controllers-k8s:main Mar 27, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants